Skip to content
Bitcoin Core integration/staging tree
C++ Python C M4 Shell Makefile Other
Branch: master
Clone or download
fanquake Merge #17896: Serialization improvements (step 2)
9b66083 Convert chain to new serialization (Pieter Wuille)
2f1b2f4 Convert VARINT to the formatter/Using approach (Pieter Wuille)
ca62563 Add a generic approach for (de)serialization of objects using code in other classes (Pieter Wuille)

Pull request description:

  This is a second carve-out from #10785.

  This introduces a const-correct generic approach for serializing objects using custom serializers (defined separately from the object being serialized), then converts VARINT to use that approach, and then converts chain.h to the new framework (including the new const-correct VARINT macro).

ACKs for top commit:
  jamesob:
    ACK 9b66083 ([`jamesob/ackr/17896.1.sipa.serialization_improvemen`](https://github.com/jamesob/bitcoin/tree/ackr/17896.1.sipa.serialization_improvemen))
  ryanofsky:
    Code review ACK 9b66083. Only change since last review is suggested lvalue reference tweak

Tree-SHA512: 2da4af1754699cb223d6beae44c587555e39ef6951448488a04783c92e2dfd4a305934f71cc3a75d06faf6d722723d8cdbd5ccb12039783f8d62039b83987bb8
Latest commit a654626 Jan 18, 2020
Permalink
Type Name Latest commit message Commit time
Failed to load latest commit information.
.github ci: Update vcpkg cache on MSBuild update Dec 23, 2019
.tx gui: Update transifex slug for 0.19 Sep 2, 2019
build-aux/m4 Merge #16110: depends: Add Android NDK support Nov 4, 2019
build_msvc Merge #17691: doc: Add missed copyright headers Jan 16, 2020
ci Merge #17900: ci: Combine 32-bit build with CentOS 7 build Jan 16, 2020
contrib Merge #17691: doc: Add missed copyright headers Jan 16, 2020
depends depends: Consistent use of package variable Jan 16, 2020
doc Merge #17819: doc: developer notes guideline on RPCExamples addresses Jan 16, 2020
share scripted-diff: Bump copyright of files changed in 2019 Dec 29, 2019
src Merge #17896: Serialization improvements (step 2) Jan 18, 2020
test Merge #17691: doc: Add missed copyright headers Jan 16, 2020
.appveyor.yml Update msvc build for Visual Studio 2019 v16.4 Dec 12, 2019
.cirrus.yml ci: remove OpenSSL installation Nov 18, 2019
.gitattributes Separate protocol versioning from clientversion Oct 29, 2014
.gitignore Merge #17452: test: update fuzz directory in .gitignore Jan 7, 2020
.python-version .python-version: Specify full version 3.5.6 Mar 2, 2019
.style.yapf test: .style.yapf: Set column_limit=160 Mar 4, 2019
.travis.yml ci: Combine 32-bit build with CentOS 7 build Jan 8, 2020
CONTRIBUTING.md Merge #17688: doc: Add "ci" prefix to CONTRIBUTING.md Jan 4, 2020
COPYING doc: Update license year range to 2020 Dec 26, 2019
INSTALL.md Update INSTALL landing redirection notice for build instructions. Oct 5, 2016
Makefile.am build: remove WINDOWS_BITS from build system Dec 16, 2019
README.md doc: Fix some misspellings Nov 4, 2019
SECURITY.md doc: Remove explicit mention of version from SECURITY.md Jun 14, 2019
autogen.sh scripted-diff: Bump copyright of files changed in 2019 Dec 29, 2019
configure.ac build: add Wdate-time to Werror flags Jan 6, 2020
libbitcoinconsensus.pc.in build: remove libcrypto as internal dependency in libbitcoinconsensus.pc Nov 19, 2019

README.md

Bitcoin Core integration/staging tree

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.

You can’t perform that action at this time.