Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2019 November upgrade: Schnorr OP_CHECKMULTISIG spec #375

Merged

Conversation

@markblundeberg
Copy link
Collaborator

commented Jun 22, 2019

No description provided.

@Mengerian
Copy link
Contributor

left a comment

Looks pretty good, I added a few suggestions to the latest commit

spec/2019-11-15-schnorrmultisig.md Outdated Show resolved Hide resolved
spec/2019-11-15-schnorrmultisig.md Outdated Show resolved Hide resolved
spec/2019-11-15-schnorrmultisig.md Show resolved Hide resolved
spec/2019-11-15-schnorrmultisig.md Outdated Show resolved Hide resolved

Mengerian pushed a commit to Mengerian/bitcoin-abc that referenced this pull request Aug 6, 2019

Implement new checkmultisig trigger logic and execution logic.
Summary: See specification at bitcoincashorg/bitcoincash.org#375

Test Plan: `make check`

Reviewers: Mengerian, jasonbcox, Fabien, #bitcoin_abc, markblundeberg

Reviewed By: #bitcoin_abc, markblundeberg

Maniphest Tasks: T528

Differential Revision: https://reviews.bitcoinabc.org/D3474
@Mengerian
Copy link
Contributor

left a comment

In addition to my other comments, can you please also update the link from the main Specification as part of this PR?

Other than that, it seems to be coming together well.

@markblundeberg markblundeberg force-pushed the markblundeberg:pr-multischnorr branch from 6f32d22 to 57b1bff Aug 11, 2019

@markblundeberg

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 11, 2019

@Mengerian I've rebased and updated per requests.

@Mengerian
Copy link
Contributor

left a comment

Looks good to me, I think it's ready to be merged.

@markblundeberg markblundeberg merged commit 92516b8 into bitcoincashorg:master Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.