Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printf used in src/streaming/MessageBuilder.cpp line 190, stdio.h not robustly included. #200

Closed
robbak opened this issue Jan 6, 2017 · 0 comments
Closed

printf used in src/streaming/MessageBuilder.cpp line 190, stdio.h not robustly included. #200

robbak opened this issue Jan 6, 2017 · 0 comments

Comments

@robbak
Copy link

robbak commented Jan 6, 2017

When building the new 1.2.0 on my FreeBSD box (gcc49 was used), the build failed with 'printf not declared in this scope.' There is a single random use of printf in the middle of this file. Should there be? Random printfs in the middle of files doesn't sound like best practice to me.

Either way, stdio.h should be more robustly included, or the printf use should be replaced with a call to the proper logging function.
@zander zander closed this as completed Jan 6, 2017
jamoes pushed a commit to jamoes/bitcoinclassic that referenced this issue Feb 3, 2017
@gandrewstone
Merge pull request bitcoinclassic#200 from ftrader-bitcoinunlimited/f…
15b5e6d 
…ix/missing_nol_netstyle_for_gui

fix a coredump in bitcoin-qt when run with `-chain_nol`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zander @robbak