Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upprintf used in src/streaming/MessageBuilder.cpp line 190, stdio.h not robustly included. #200
Comments
jamoes
pushed a commit
to jamoes/bitcoinclassic
that referenced
this issue
Feb 3, 2017
…ix/missing_nol_netstyle_for_gui fix a coredump in bitcoin-qt when run with `-chain_nol`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When building the new 1.2.0 on my FreeBSD box (gcc49 was used), the build failed with 'printf not declared in this scope.' There is a single random use of printf in the middle of this file. Should there be? Random printfs in the middle of files doesn't sound like best practice to me.
Either way, stdio.h should be more robustly included, or the printf use should be replaced with a call to the proper logging function.