Update libsecp256k1 #224

Merged
merged 1 commit into from Feb 18, 2017

Conversation

Projects
None yet
3 participants
@deadalnix

As per title.

V2.0 because github is a piece of shit.

@jamoes

This comment has been minimized.

Show comment
Hide comment
@jamoes

jamoes Feb 15, 2017

I think it would be preferable to preserve the entire git commit history rather than squashing this into a single commit. It looks like you were able to successfully do this for the comparable BU pull request: BitcoinUnlimited/BitcoinUnlimited#237. Could you do that here as well?

jamoes commented Feb 15, 2017

I think it would be preferable to preserve the entire git commit history rather than squashing this into a single commit. It looks like you were able to successfully do this for the comparable BU pull request: BitcoinUnlimited/BitcoinUnlimited#237. Could you do that here as well?

@zander

This comment has been minimized.

Show comment
Hide comment
@zander

zander Feb 15, 2017

@jamoes This is a 3rd party library, Classic won't claim to be upstream or a place where this library is further developed.
The importing of a snapshot is purely to help people compile Bitcoin and to ensure we have a coherent whole (since upstream doesn't do releases we can point to).

I agree this library existing under 'src/' is weird and not very clear. Having a 3rdparty dir at the rootlevel would be better, but that would be a huge change which I am not a fan of at this time.

zander commented Feb 15, 2017

@jamoes This is a 3rd party library, Classic won't claim to be upstream or a place where this library is further developed.
The importing of a snapshot is purely to help people compile Bitcoin and to ensure we have a coherent whole (since upstream doesn't do releases we can point to).

I agree this library existing under 'src/' is weird and not very clear. Having a 3rdparty dir at the rootlevel would be better, but that would be a huge change which I am not a fan of at this time.

@zander zander merged commit c8103b0 into bitcoinclassic:master Feb 18, 2017

@deadalnix deadalnix deleted the deadalnix:classiclibsecpup branch Feb 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment