Workaround for pkh max satisfaction weight
#775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in miniscript where they fail to take into consideration an `OP_PUSH..` (4 weight units) when calculating `max_satisfaction_weight` for `pkh` script types. We add this weight explicitly for `pkh` script types during coin selection.
Member
Author
|
@afilini We call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug in miniscript where they fail to take into consideration an
OP_PUSH..(4 weight units) when calculatingmax_satisfaction_weightforpkhscript types.We add this weight explicitly for
pkhscript types during coin selection.Notes to the reviewers
The alternative is to patch miniscript (as @afilini mentioned).
Changelog notice
Implement workaround for miniscript
max_satisfaction_weightbug withpkhscripts.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing