{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":718001100,"defaultBranch":"main","name":"coinselect","ownerLogin":"bitcoinerlab","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-11-13T06:45:42.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/98774126?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717424716.0","currentOid":""},"activityList":{"items":[{"before":"b568bf81e1a0d5eb9347a4d90c2132474a2ac95d","after":"a0ae40acbd223f72b0c5b344e8ec00dbcac85744","ref":"refs/heads/main","pushedAt":"2024-06-03T14:24:44.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"Merge pull request #5 from bitcoinerlab/fix/utxo-zero-value-validation\n\nFix: Allow UTXO with value zero in validation","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2331298426\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoinerlab/coinselect/issues/5\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoinerlab/coinselect/pull/5/hovercard\" href=\"https://github.com/bitcoinerlab/coinselect/pull/5\">#5</a> from bitcoinerlab/fix/utxo-zero-value-validation"}},{"before":null,"after":"fac662fa268d8558d988826716d67309bd5828de","ref":"refs/heads/fix/utxo-zero-value-validation","pushedAt":"2024-06-03T14:22:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"Fix: Allow UTXO with value zero in validation\n\nPreviously, the validation function did not consider UTXOs with a value of zero, leading to issues in certain scenarios. This fix updates the validation logic to allow UTXOs with a value of zero, as such UTXOs can exist.\n\nReference: https://blockstream.info/testnet/tx/a063dbdc23cf969df020536f75c431167a2bbf29d6215a2067495ac46991c954","shortMessageHtmlLink":"Fix: Allow UTXO with value zero in validation"}},{"before":"038188816339619630e8605e2d524a7ae4ee09d2","after":"b568bf81e1a0d5eb9347a4d90c2132474a2ac95d","ref":"refs/heads/main","pushedAt":"2023-12-09T06:36:11.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"Merge pull request #2 from bitcoinerlab/weights\n\nAdaptations in Weight Calculation Methods","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2033663829\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoinerlab/coinselect/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoinerlab/coinselect/pull/2/hovercard\" href=\"https://github.com/bitcoinerlab/coinselect/pull/2\">#2</a> from bitcoinerlab/weights"}},{"before":null,"after":"e33e2008d3469c5b944c46c6ca7329253cecfe70","ref":"refs/heads/weights","pushedAt":"2023-12-09T06:35:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"Adaptations in Weight Calculation Methods\n\nThis update ensure that `@bitcoinerlab/coinselect` takes full advantage of the recent improvements in the `@bitcoinerlab/descriptors` package, particularly the new weight calculation methods. This alignment enhances the performance of coin selection and transaction size estimation since it now relies on smarter caching strategies implemented in `@bitcoinerlab/descriptors`.\n\nIt aligns with the recent enhancements and new functionalities in weight calculation methods introduced in `@bitcoinerlab/descriptors` ([PR #32](https://github.com/bitcoinerlab/descriptors/pull/32)).\n\n**Key Changes:**\n1. **Package Version and Dependencies:**\n   - Upgraded `@bitcoinerlab/coinselect` from version `1.1.0` to `1.2.0`.\n   - Updated the dependency on `@bitcoinerlab/descriptors` to version `2.1.0` to leverage the latest enhancements.\n\n2. **Code Refactoring:**\n   - Removed local implementations of weight calculations (`inputWeight` and `outputWeight`) and replaced them with the updated methods from `@bitcoinerlab/descriptors`.\n   - Simplified and streamlined the code by removing redundant functions and logic, relying on the improved functionalities in the `descriptors` package.\n\n3. **Validation and Dust Calculation Adjustments:**\n   - Updated the validation logic to incorporate changes in dust calculation and fee rate validation.\n   - Ensured compatibility with the new weight calculation methods in handling UTXOs and transaction outputs.\n\n4. **Test Suite Enhancements:**\n   - Revised test cases to align with the updated logic and methods.\n\nUpdates and modifications have been appropriately commented and documented within the code.","shortMessageHtmlLink":"Adaptations in Weight Calculation Methods"}},{"before":"87de51eea9a60630b281e60fa0428fed98013be5","after":"038188816339619630e8605e2d524a7ae4ee09d2","ref":"refs/heads/main","pushedAt":"2023-11-30T07:43:59.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"Merge pull request #1 from bitcoinerlab/maxFundsWithTargets\n\nUpdate `maxFunds` Algorithm to Accept Fixed-Value Targets","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2018063447\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoinerlab/coinselect/issues/1\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoinerlab/coinselect/pull/1/hovercard\" href=\"https://github.com/bitcoinerlab/coinselect/pull/1\">#1</a> from bitcoinerlab/maxFundsWithTargets"}},{"before":null,"after":"927ab523d74b382ad761f51ef6b3d38db74e6ee8","ref":"refs/heads/maxFundsWithTargets","pushedAt":"2023-11-30T07:43:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"Update `maxFunds` Algorithm to Accept Fixed-Value Targets\n\nThis update to the `maxFunds` algorithm in the @bitcoinerlab/coinselect library enhances its functionality by allowing the inclusion of fixed-value targets in addition to the remainder. The change ensures more flexibility in handling scenarios where a combination of specific targets and the maximum possible fund transfer to a recipient is desired.\n\nThe README.md and relevant test fixtures have been updated to reflect this change, and the package version has been bumped to 1.1.0 to indicate this significant update.\n\nKey Changes:\n- Modified `maxFunds` function signature to include an additional `targets` parameter.\n- Updated README.md with new usage examples and descriptions.\n- Adjusted test fixtures to cover the updated functionality of `maxFunds`.\n- Version bump in package.json and package-lock.json to 1.1.0.\n\nThese changes enhance the utility of the `maxFunds` algorithm, aligning it with practical use cases in Bitcoin transaction management.","shortMessageHtmlLink":"Update <code>maxFunds</code> Algorithm to Accept Fixed-Value Targets"}},{"before":"00c90c78c9ba60725513315b7b95e22f12afb5b2","after":"87de51eea9a60630b281e60fa0428fed98013be5","ref":"refs/heads/main","pushedAt":"2023-11-23T18:21:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"package: properly scope the package name to @bitcoinerlab org","shortMessageHtmlLink":"package: properly scope the package name to <a class=\"user-mention notranslate\" data-hovercard-type=\"organization\" data-hovercard-url=\"/orgs/bitcoinerlab/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/bitcoinerlab\">@bitcoinerlab</a> org"}},{"before":"260d6921a9744a4422c8c34247505310c8f775d2","after":"00c90c78c9ba60725513315b7b95e22f12afb5b2","ref":"refs/heads/main","pushedAt":"2023-11-23T17:21:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: better express UTXO rejection","shortMessageHtmlLink":"docs: better express UTXO rejection"}},{"before":"076efcf5de2c918fd1579ad057b19d1b55ffb66f","after":"260d6921a9744a4422c8c34247505310c8f775d2","ref":"refs/heads/main","pushedAt":"2023-11-23T17:19:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: more precise language in the miniscript section","shortMessageHtmlLink":"docs: more precise language in the miniscript section"}},{"before":"b4b01e43b00cfbab169558150b2c13274053abf8","after":"076efcf5de2c918fd1579ad057b19d1b55ffb66f","ref":"refs/heads/main","pushedAt":"2023-11-23T17:05:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"set 1.0 version","shortMessageHtmlLink":"set 1.0 version"}},{"before":"7022a72757095815ef65eddefc880bb8cb01704d","after":"b4b01e43b00cfbab169558150b2c13274053abf8","ref":"refs/heads/main","pushedAt":"2023-11-23T17:04:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: document that utxos are excluded if they don't provide enough value","shortMessageHtmlLink":"docs: document that utxos are excluded if they don't provide enough v…"}},{"before":"17eb7926bf820310ab3b2d630d9c5daed2658d1d","after":"7022a72757095815ef65eddefc880bb8cb01704d","ref":"refs/heads/main","pushedAt":"2023-11-23T16:24:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: provide typedoc documentation in all exported functions","shortMessageHtmlLink":"docs: provide typedoc documentation in all exported functions"}},{"before":"2cbf7f2b05e9af2f568dec774c2c2f785b787236","after":"17eb7926bf820310ab3b2d630d9c5daed2658d1d","ref":"refs/heads/main","pushedAt":"2023-11-23T14:37:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"reorganize exported defaults","shortMessageHtmlLink":"reorganize exported defaults"}},{"before":"0cd211b00ff410237ba8bb3676ee1b5dc522edef","after":"2cbf7f2b05e9af2f568dec774c2c2f785b787236","ref":"refs/heads/main","pushedAt":"2023-11-23T12:08:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: fix the witnessScript keys","shortMessageHtmlLink":"docs: fix the witnessScript keys"}},{"before":"ccbc4b4ace9244301cc8e2a567eb9f22edeeea9a","after":"0cd211b00ff410237ba8bb3676ee1b5dc522edef","ref":"refs/heads/main","pushedAt":"2023-11-23T12:04:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: fix avoidChange","shortMessageHtmlLink":"docs: fix avoidChange"}},{"before":"1e77a1ebc1c02070de325652914b5341fab2fa20","after":"ccbc4b4ace9244301cc8e2a567eb9f22edeeea9a","ref":"refs/heads/main","pushedAt":"2023-11-23T11:59:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: remove the Notice warning - almost ready for relasing it","shortMessageHtmlLink":"docs: remove the Notice warning - almost ready for relasing it"}},{"before":"0eabfb0ebea3acdf2033c285647b424d787ca651","after":"1e77a1ebc1c02070de325652914b5341fab2fa20","ref":"refs/heads/main","pushedAt":"2023-11-23T11:56:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: document miniscript integration","shortMessageHtmlLink":"docs: document miniscript integration"}},{"before":"2b4c49f76f717945b97a1cb06d745625c07a4fd6","after":"0eabfb0ebea3acdf2033c285647b424d787ca651","ref":"refs/heads/main","pushedAt":"2023-11-23T10:13:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: Algorithms section and small edits on rest of sections","shortMessageHtmlLink":"docs: Algorithms section and small edits on rest of sections"}},{"before":"5ff7e6cb5ba6955ca3b0c33d81cf86f0afbba999","after":"2b4c49f76f717945b97a1cb06d745625c07a4fd6","ref":"refs/heads/main","pushedAt":"2023-11-22T17:36:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: clarification on change not being added if below dust","shortMessageHtmlLink":"docs: clarification on change not being added if below dust"}},{"before":"5de11e003b89b9a1e01aefc116a6f12e2da4650e","after":"5ff7e6cb5ba6955ca3b0c33d81cf86f0afbba999","ref":"refs/heads/main","pushedAt":"2023-11-22T17:32:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: use typescript code blocks instead of json","shortMessageHtmlLink":"docs: use typescript code blocks instead of json"}},{"before":"7ac4c2bb0b6ae485f399d06ab5095ee85c663f19","after":"5de11e003b89b9a1e01aefc116a6f12e2da4650e","ref":"refs/heads/main","pushedAt":"2023-11-22T17:29:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"docs: initial work on the README file","shortMessageHtmlLink":"docs: initial work on the README file"}},{"before":"971c16ec239cae19319fb2f85161ae2ef5152441","after":"7ac4c2bb0b6ae485f399d06ab5095ee85c663f19","ref":"refs/heads/main","pushedAt":"2023-11-22T12:53:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"test: correct expected results in coinselect fixtures. get rid of the fee since it is unreliable after bitcoinjs parsing and also get rid of scripts too","shortMessageHtmlLink":"test: correct expected results in coinselect fixtures. get rid of the…"}},{"before":"75b340a5f20e8dbf36043d0462631d30df6e53aa","after":"971c16ec239cae19319fb2f85161ae2ef5152441","ref":"refs/heads/main","pushedAt":"2023-11-22T12:21:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"todo: updated todo - implementation complete. documentation missing","shortMessageHtmlLink":"todo: updated todo - implementation complete. documentation missing"}},{"before":"1676df313c72b3b128c7b57c72aabe5e91eca8a6","after":"75b340a5f20e8dbf36043d0462631d30df6e53aa","ref":"refs/heads/main","pushedAt":"2023-11-22T12:20:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"tests: test failures on no inputs or no outputs","shortMessageHtmlLink":"tests: test failures on no inputs or no outputs"}},{"before":"9410271a52bfd38852bf6048f8fdbd23e33224c2","after":"1676df313c72b3b128c7b57c72aabe5e91eca8a6","ref":"refs/heads/main","pushedAt":"2023-11-22T11:54:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"tests: remove test fixture with dusty outputs from set of valid tests","shortMessageHtmlLink":"tests: remove test fixture with dusty outputs from set of valid tests"}},{"before":"c37c9dd1b7d2639eeeef9e50f08a797a619c6983","after":"9410271a52bfd38852bf6048f8fdbd23e33224c2","ref":"refs/heads/main","pushedAt":"2023-11-22T11:16:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"test dusty errors. remove incorrect assertions","shortMessageHtmlLink":"test dusty errors. remove incorrect assertions"}},{"before":"afa10fe25c341ebe00c9915889c5691f0cadbe51","after":"c37c9dd1b7d2639eeeef9e50f08a797a619c6983","ref":"refs/heads/main","pushedAt":"2023-11-22T09:10:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"Dust calculation uses internal isSegwit function that assumes all p2sh addr() to be segwit. Add tests for dust. Document the rounding error bug in Bitcoin Core","shortMessageHtmlLink":"Dust calculation uses internal isSegwit function that assumes all p2s…"}},{"before":"046c70ae28b414871a8551db26c75e6e4c205c86","after":"afa10fe25c341ebe00c9915889c5691f0cadbe51","ref":"refs/heads/main","pushedAt":"2023-11-21T18:10:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"export isDust, add further assertions and update TODO tasks","shortMessageHtmlLink":"export isDust, add further assertions and update TODO tasks"}},{"before":"9d9674578a326b80541b365828894d491f14dbc3","after":"046c70ae28b414871a8551db26c75e6e4c205c86","ref":"refs/heads/main","pushedAt":"2023-11-21T17:48:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"Return fee and vsize of the final tx. Also assert that the final fee rate is larger than the original one","shortMessageHtmlLink":"Return fee and vsize of the final tx. Also assert that the final fee …"}},{"before":"84faf3827d619f68abf4227fe69df2953923244c","after":"9d9674578a326b80541b365828894d491f14dbc3","ref":"refs/heads/main","pushedAt":"2023-11-21T16:29:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"landabaso","name":"Jose-Luis Landabaso","path":"/landabaso","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4365458?s=80&v=4"},"commit":{"message":"tests: test sendMaxFunds algo","shortMessageHtmlLink":"tests: test sendMaxFunds algo"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWwoxHQA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoinerlab/coinselect"}