diff --git a/core/pom.xml b/core/pom.xml
index a256c4a32ba..c32ff64ac6d 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -150,7 +150,7 @@
Note that this is NOT called when every block arrives. Instead it is called when the transaction
* transitions between confidence states, ie, from not being seen in the chain to being seen (not necessarily in
* the best chain). If you want to know when the transaction gets buried under another block, implement a
- * {@link BlockChainListener}, attach it to a {@link BlockChain} and then use the getters on the
+ * {@link org.bitcoinj.core.listeners.BlockChainListener}, attach it to a {@link BlockChain} and then use the getters on the
* confidence object to determine the new depth. Called when peers are discovered, this happens at startup of {@link PeerGroup} or if we run out of
+ * Called when peers are discovered, this happens at startup of {@link org.bitcoinj.core.PeerGroup} or if we run out of
* suitable {@link Peer}s to connect to. Called by the {@link BlockChain} when we receive a new {@link FilteredBlock} that contains the given
+ * Called by the {@link BlockChain} when we receive a new {@link org.bitcoinj.core.FilteredBlock} that contains the given
* transaction hash in its merkle tree. A transaction may be received multiple times if is included into blocks in parallel chains. The blockType
diff --git a/core/src/main/java/org/bitcoinj/crypto/TransactionSignature.java b/core/src/main/java/org/bitcoinj/crypto/TransactionSignature.java
index 07877f3fc35..2abc38736f9 100644
--- a/core/src/main/java/org/bitcoinj/crypto/TransactionSignature.java
+++ b/core/src/main/java/org/bitcoinj/crypto/TransactionSignature.java
@@ -186,7 +186,7 @@ public ECKey.ECDSASignature toCanonicalised() {
* @param requireCanonicalEncoding if the encoding of the signature must
* be canonical.
* @throws RuntimeException if the signature is invalid or unparseable in some way.
- * @deprecated use {@link #decodeFromBitcoin(byte[], boolean, boolean} instead}.
+ * @deprecated use {@link #decodeFromBitcoin(byte[], boolean, boolean)} instead.
*/
@Deprecated
public static TransactionSignature decodeFromBitcoin(byte[] bytes,
diff --git a/core/src/main/java/org/bitcoinj/kits/WalletAppKit.java b/core/src/main/java/org/bitcoinj/kits/WalletAppKit.java
index a05767a4526..fe2372007d8 100644
--- a/core/src/main/java/org/bitcoinj/kits/WalletAppKit.java
+++ b/core/src/main/java/org/bitcoinj/kits/WalletAppKit.java
@@ -130,7 +130,7 @@ public WalletAppKit setAutoSave(boolean value) {
/**
* If you want to learn about the sync process, you can provide a listener here. For instance, a
- * {@link org.bitcoinj.core.DownloadProgressTracker} is a good choice. This has no effect unless setBlockingStartup(false) has been called
+ * {@link org.bitcoinj.core.listeners.DownloadProgressTracker} is a good choice. This has no effect unless setBlockingStartup(false) has been called
* too, due to some missing implementation code.
*/
public WalletAppKit setDownloadListener(DownloadProgressTracker listener) {
diff --git a/core/src/main/java/org/bitcoinj/net/ClientConnectionManager.java b/core/src/main/java/org/bitcoinj/net/ClientConnectionManager.java
index 23d493436d9..c16aec56ed5 100644
--- a/core/src/main/java/org/bitcoinj/net/ClientConnectionManager.java
+++ b/core/src/main/java/org/bitcoinj/net/ClientConnectionManager.java
@@ -25,7 +25,7 @@
* A generic interface for an object which keeps track of a set of open client connections, creates new ones and
* ensures they are serviced properly. When the service is {@link com.google.common.util.concurrent.Service#stop()}ed, all connections will be closed and
+ * When the service is stopped, all connections will be closed and
* the appropriate connectionClosed() calls must be made.
DNS seeds do not attempt to enumerate every peer on the network. {@link DnsDiscovery#getPeers(long, java.util.concurrent.TimeUnit)} + *
DNS seeds do not attempt to enumerate every peer on the network. {@link #getPeers(long, long, java.util.concurrent.TimeUnit)} * will return up to 30 random peers from the set of those returned within the timeout period. If you want more peers * to connect to, you need to discover them via other means (like addr broadcasts).
*/ diff --git a/core/src/main/java/org/bitcoinj/net/discovery/PeerDiscovery.java b/core/src/main/java/org/bitcoinj/net/discovery/PeerDiscovery.java index 72452c25d01..e0792bc0bef 100644 --- a/core/src/main/java/org/bitcoinj/net/discovery/PeerDiscovery.java +++ b/core/src/main/java/org/bitcoinj/net/discovery/PeerDiscovery.java @@ -29,7 +29,7 @@ public interface PeerDiscovery { /** * Returns an array of addresses. This method may block. - * @param services Required services as a bitmask, e.g. {@link VersionMessage#NODE_NETWORK}. + * @param services Required services as a bitmask, e.g. {@link org.bitcoinj.core.VersionMessage#NODE_NETWORK}. */ InetSocketAddress[] getPeers(long services, long timeoutValue, TimeUnit timeoutUnit) throws PeerDiscoveryException; diff --git a/core/src/main/java/org/bitcoinj/protocols/channels/IPaymentChannelClient.java b/core/src/main/java/org/bitcoinj/protocols/channels/IPaymentChannelClient.java index 398cf2cefc2..0bb31e5f436 100644 --- a/core/src/main/java/org/bitcoinj/protocols/channels/IPaymentChannelClient.java +++ b/core/src/main/java/org/bitcoinj/protocols/channels/IPaymentChannelClient.java @@ -46,7 +46,7 @@ public interface IPaymentChannelClient { * intending to reopen the channel later. There is likely little reason to use this in a stateless protocol. * *Note that this MUST still be called even after either - * {@link PaymentChannelClient.ClientConnection#destroyConnection(org.bitcoinj.protocols.channels.PaymentChannelCloseException.CloseReason)} or + * {@link ClientConnection#destroyConnection(org.bitcoinj.protocols.channels.PaymentChannelCloseException.CloseReason)} or * {@link IPaymentChannelClient#settle()} is called, to actually handle the connection close logic.
*/ void connectionClosed(); @@ -55,7 +55,7 @@ public interface IPaymentChannelClient { *Settles the channel, notifying the server it can broadcast the most recent payment transaction.
* *Note that this only generates a CLOSE message for the server and calls - * {@link PaymentChannelClient.ClientConnection#destroyConnection(org.bitcoinj.protocols.channels.PaymentChannelCloseException.CloseReason)} + * {@link ClientConnection#destroyConnection(org.bitcoinj.protocols.channels.PaymentChannelCloseException.CloseReason)} * to settle the connection, it does not actually handle connection close logic, and * {@link PaymentChannelClient#connectionClosed()} must still be called after the connection fully settles.
* diff --git a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClient.java b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClient.java index 3bb0ed1b8ae..ed469c2f8d4 100644 --- a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClient.java +++ b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClient.java @@ -566,7 +566,7 @@ private void receiveClose(Protos.TwoWayChannelMessage msg) throws VerificationEx * intending to reopen the channel later. There is likely little reason to use this in a stateless protocol. * *Note that this MUST still be called even after either - * {@link ClientConnection#destroyConnection(org.bitcoinj.protocols.channels.PaymentChannelCloseException.CloseReason)} or + * {@link IPaymentChannelClient.ClientConnection#destroyConnection(PaymentChannelCloseException.CloseReason)} or * {@link PaymentChannelClient#settle()} is called, to actually handle the connection close logic.
*/ @Override @@ -586,7 +586,7 @@ public void connectionClosed() { * payment transaction. * *Note that this only generates a CLOSE message for the server and calls - * {@link ClientConnection#destroyConnection(CloseReason)} to settle the connection, it does not + * {@link IPaymentChannelClient.ClientConnection#destroyConnection(PaymentChannelCloseException.CloseReason)} to settle the connection, it does not * actually handle connection close logic, and {@link PaymentChannelClient#connectionClosed()} must still be called * after the connection fully closes.
* diff --git a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClientConnection.java b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClientConnection.java index 43491ed85a6..038bc06a140 100644 --- a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClientConnection.java +++ b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClientConnection.java @@ -104,7 +104,7 @@ public PaymentChannelClientConnection(InetSocketAddress server, int timeoutSecon /** * Attempts to open a new connection to and open a payment channel with the given host and port, blocking until the - * connection is open. The server is requested to keep the channel open for {@param timeWindow} + * connection is open. The server is requested to keep the channel open for {@code timeWindow} * seconds. If the server proposes a longer time the channel will be closed. * * @param server The host/port pair where the server is listening. @@ -134,7 +134,7 @@ public PaymentChannelClientConnection(InetSocketAddress server, int timeoutSecon /** * Attempts to open a new connection to and open a payment channel with the given host and port, blocking until the - * connection is open. The server is requested to keep the channel open for {@param timeWindow} + * connection is open. The server is requested to keep the channel open for {@code timeWindow} * seconds. If the server proposes a longer time the channel will be closed. * * @param server The host/port pair where the server is listening. diff --git a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClientState.java b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClientState.java index b9b5785b3da..d1e27d60e8a 100644 --- a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClientState.java +++ b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelClientState.java @@ -211,7 +211,7 @@ public synchronized State getState() { * Creates the initial multisig contract and incomplete refund transaction which can be requested at the appropriate * time using {@link PaymentChannelV1ClientState#getIncompleteRefundTransaction} and * {@link PaymentChannelV1ClientState#getContract()}. The way the contract is crafted can be adjusted by - * overriding {@link PaymentChannelV1ClientState#editContractSendRequest(org.bitcoinj.wallet.Wallet.SendRequest)}. + * overriding {@link PaymentChannelV1ClientState#editContractSendRequest(org.bitcoinj.wallet.SendRequest)}. * By default unconfirmed coins are allowed to be used, as for micropayments the risk should be relatively low. * * @throws ValueOutOfRangeException if the value being used is too small to be accepted by the network @@ -225,7 +225,7 @@ public void initiate() throws ValueOutOfRangeException, InsufficientMoneyExcepti * Creates the initial multisig contract and incomplete refund transaction which can be requested at the appropriate * time using {@link PaymentChannelV1ClientState#getIncompleteRefundTransaction} and * {@link PaymentChannelV1ClientState#getContract()}. The way the contract is crafted can be adjusted by - * overriding {@link PaymentChannelV1ClientState#editContractSendRequest(org.bitcoinj.wallet.Wallet.SendRequest)}. + * overriding {@link PaymentChannelV1ClientState#editContractSendRequest(org.bitcoinj.wallet.SendRequest)}. * By default unconfirmed coins are allowed to be used, as for micropayments the risk should be relatively low. * @param userKey Key derived from a user password, needed for any signing when the wallet is encrypted. * The wallet KeyCrypter is assumed. @@ -426,7 +426,7 @@ public synchronized Coin getValueSpent() { /** * Gets the contract without changing the state machine - * @return + * @return the {@link Transaction} */ protected abstract Transaction getContractInternal(); @@ -435,7 +435,7 @@ public synchronized Coin getValueSpent() { /** * Gets the script that is signed. In the case of a P2SH contract this is the * script inside the P2SH script. - * @return + * @return the {@link Script} */ protected abstract Script getSignedScript(); } diff --git a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelServer.java b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelServer.java index f53daf22ba2..826a4f8dba9 100644 --- a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelServer.java +++ b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelServer.java @@ -551,7 +551,7 @@ public void onFailure(Throwable t) { * resume this channel in the future and stops generating messages for the client. * *Note that this MUST still be called even after either - * {@link ServerConnection#destroyConnection(CloseReason)} or + * {@link ServerConnection#destroyConnection(PaymentChannelCloseException.CloseReason)} or * {@link PaymentChannelServer#close()} is called to actually handle the connection close logic.
*/ public void connectionClosed() { @@ -594,7 +594,7 @@ public void connectionOpen() { /** *Closes the connection by generating a settle message for the client and calls - * {@link ServerConnection#destroyConnection(CloseReason)}. Note that this does not broadcast + * {@link ServerConnection#destroyConnection(PaymentChannelCloseException.CloseReason)}. Note that this does not broadcast * the payment transaction and the client may still resume the same channel if they reconnect
**
Note that {@link PaymentChannelServer#connectionClosed()} must still be called after the connection fully diff --git a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelServerState.java b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelServerState.java index 568e1d9ac9d..3bfa75aed4c 100644 --- a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelServerState.java +++ b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelServerState.java @@ -374,7 +374,7 @@ public Script getContractScript() { /** * Gets the script that signatures should sign against. This is never a P2SH * script, rather the script that would be inside a P2SH script. - * @return + * @return the {@link Script} */ protected abstract Script getSignedScript(); diff --git a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV1ClientState.java b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV1ClientState.java index 86e32bc0a6d..30562274b1f 100644 --- a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV1ClientState.java +++ b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV1ClientState.java @@ -116,7 +116,7 @@ public int getMajorVersion() { * Creates the initial multisig contract and incomplete refund transaction which can be requested at the appropriate * time using {@link PaymentChannelV1ClientState#getIncompleteRefundTransaction} and * {@link PaymentChannelV1ClientState#getContract()}. The way the contract is crafted can be adjusted by - * overriding {@link PaymentChannelV1ClientState#editContractSendRequest(org.bitcoinj.core.Wallet.SendRequest)}. + * overriding {@link PaymentChannelV1ClientState#editContractSendRequest(org.bitcoinj.wallet.SendRequest)}. * By default unconfirmed coins are allowed to be used, as for micropayments the risk should be relatively low. * @param userKey Key derived from a user password, needed for any signing when the wallet is encrypted. * The wallet KeyCrypter is assumed. diff --git a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV1ServerState.java b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV1ServerState.java index da07ae0c0b6..60951a3a104 100644 --- a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV1ServerState.java +++ b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV1ServerState.java @@ -179,12 +179,13 @@ private void signMultisigInput(Transaction tx, Transaction.SigHash hashType, boo /** *
Closes this channel and broadcasts the highest value payment transaction on the network.
* - *This will set the state to {@link State#CLOSED} if the transaction is successfully broadcast on the network. - * If we fail to broadcast for some reason, the state is set to {@link State#ERROR}.
+ *This will set the state to {@link PaymentChannelServerState.State#CLOSED} if the transaction is successfully + * broadcast on the network. If we fail to broadcast for some reason, the state is set to + * {@link PaymentChannelServerState.State#ERROR}.
* - *If the current state is before {@link State#READY} (ie we have not finished initializing the channel), we - * simply set the state to {@link State#CLOSED} and let the client handle getting its refund transaction confirmed. - *
+ *If the current state is before {@link PaymentChannelServerState.State#READY} (ie we have not finished + * initializing the channel), we simply set the state to {@link PaymentChannelServerState.State#CLOSED} and let the + * client handle getting its refund transaction confirmed.
* * @return a future which completes when the provided multisig contract successfully broadcasts, or throws if the * broadcast fails for some reason. Note that if the network simply rejects the transaction, this future diff --git a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV2ServerState.java b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV2ServerState.java index d1f94bc6bf1..18fe59127ab 100644 --- a/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV2ServerState.java +++ b/core/src/main/java/org/bitcoinj/protocols/channels/PaymentChannelV2ServerState.java @@ -116,7 +116,6 @@ protected void verifyContract(final Transaction contract) { /** * Creates a P2SH script outputting to the client and server pubkeys - * @return */ @Override protected Script createOutputScript() { diff --git a/core/src/main/java/org/bitcoinj/protocols/payments/PaymentProtocol.java b/core/src/main/java/org/bitcoinj/protocols/payments/PaymentProtocol.java index 26df1e534f1..a19bcb453be 100644 --- a/core/src/main/java/org/bitcoinj/protocols/payments/PaymentProtocol.java +++ b/core/src/main/java/org/bitcoinj/protocols/payments/PaymentProtocol.java @@ -54,8 +54,8 @@ public class PaymentProtocol { /** * Create a payment request with one standard pay to address output. You may want to sign the request using - * {@link #signPaymentRequest}. Use {@link Protos.PaymentRequest.Builder#build} to get the actual payment - * request. + * {@link #signPaymentRequest}. Use {@link org.bitcoin.protocols.payments.Protos.PaymentRequest.Builder#build} + * to get the actual payment request. * * @param params network parameters * @param amount amount of coins to request, or null @@ -74,7 +74,7 @@ public static Protos.PaymentRequest.Builder createPaymentRequest(NetworkParamete /** * Create a payment request. You may want to sign the request using {@link #signPaymentRequest}. Use - * {@link Protos.PaymentRequest.Builder#build} to get the actual payment request. + * {@link org.bitcoin.protocols.payments.Protos.PaymentRequest.Builder#build} to get the actual payment request. * * @param params network parameters * @param outputs list of outputs to request coins to @@ -157,7 +157,7 @@ public static void signPaymentRequest(Protos.PaymentRequest.Builder paymentReque * * @param paymentRequest Payment request to verify. * @param trustStore KeyStore of trusted root certificate authorities. - * @return verification data, or null if no PKI method was specified in the {@link Protos.PaymentRequest}. + * @return verification data, or null if no PKI method was specified in the {@link org.bitcoin.protocols.payments.Protos.PaymentRequest}. * @throws PaymentProtocolException if payment request could not be verified. */ @Nullable diff --git a/core/src/main/java/org/bitcoinj/protocols/payments/PaymentSession.java b/core/src/main/java/org/bitcoinj/protocols/payments/PaymentSession.java index 8988f89c6d5..82a7347f60e 100644 --- a/core/src/main/java/org/bitcoinj/protocols/payments/PaymentSession.java +++ b/core/src/main/java/org/bitcoinj/protocols/payments/PaymentSession.java @@ -46,8 +46,8 @@ * *If initialized with a BitcoinURI or a url, a network request is made for the payment request object and a @@ -57,10 +57,10 @@ * amount and recipient are correct, perform any additional steps, and then construct a list of transactions to pass to * the sendPayment method.
* - *Call sendPayment with a list of transactions that will be broadcast. A {@link Protos.Payment} message will be sent + *
Call sendPayment with a list of transactions that will be broadcast. A {@link org.bitcoin.protocols.payments.Protos.Payment} message will be sent * to the merchant if a payment url is provided in the PaymentRequest. NOTE: sendPayment does NOT broadcast the * transactions to the bitcoin network. Instead it returns a ListenableFuture that will be notified when a - * {@link Protos.PaymentACK} is received from the merchant. Typically a wallet will show the message to the user + * {@link org.bitcoin.protocols.payments.Protos.PaymentACK} is received from the merchant. Typically a wallet will show the message to the user * as a confirmation message that the payment is now "processing" or that an error occurred, and then broadcast the * tx itself later if needed.
* @@ -81,7 +81,7 @@ public class PaymentSession { /** *Returns a future that will be notified with a PaymentSession object after it is fetched using the provided uri. - * uri is a BIP-72-style BitcoinURI object that specifies where the {@link Protos.PaymentRequest} object may + * uri is a BIP-72-style BitcoinURI object that specifies where the {@link org.bitcoin.protocols.payments.Protos.PaymentRequest} object may * be fetched in the r= parameter.
* *If the payment request object specifies a PKI method, then the system trust store will be used to verify
@@ -94,7 +94,7 @@ public static ListenableFuture
This signer is always implicitly added into every wallet and it is the first signer to be executed during tx * completion. As the first signer to create a signature, it stores derivation path of the signing key in a given - * {@link ProposedTransaction} object that will be also passed then to the next signer in chain. This allows other + * {@link TransactionSigner.ProposedTransaction} object that will be also passed then to the next signer in chain. This allows other * signers to use correct signing key for P2SH inputs, because all the keys involved in a single P2SH address have * the same derivation path.
*This signer always uses {@link org.bitcoinj.core.Transaction.SigHash#ALL} signing mode.
diff --git a/core/src/main/java/org/bitcoinj/utils/BtcFormat.java b/core/src/main/java/org/bitcoinj/utils/BtcFormat.java index a8d2bbfdf53..babf72aac5b 100644 --- a/core/src/main/java/org/bitcoinj/utils/BtcFormat.java +++ b/core/src/main/java/org/bitcoinj/utils/BtcFormat.java @@ -1378,7 +1378,6 @@ private static DecimalFormatSymbols setSymbolAndCode(DecimalFormat numberFormat, * * @param scale Number of places the decimal point will be shifted when formatting * a quantity of satoshis. - * @return The DecimalFormatSymbols before changing */ protected static void prefixUnitsIndicator(DecimalFormat numberFormat, int scale) { checkState(Thread.holdsLock(numberFormat)); // make sure caller intends to reset before changing diff --git a/core/src/main/java/org/bitcoinj/wallet/KeyChainGroup.java b/core/src/main/java/org/bitcoinj/wallet/KeyChainGroup.java index 6aba8d79d79..368626ee4df 100644 --- a/core/src/main/java/org/bitcoinj/wallet/KeyChainGroup.java +++ b/core/src/main/java/org/bitcoinj/wallet/KeyChainGroup.java @@ -594,7 +594,6 @@ public BloomFilter getBloomFilter(int size, double falsePositiveRate, long nTwea return filter; } - /** {@inheritDoc} */ public boolean isRequiringUpdateAllBloomFilter() { throw new UnsupportedOperationException(); // Unused. } diff --git a/core/src/main/java/org/bitcoinj/wallet/SendRequest.java b/core/src/main/java/org/bitcoinj/wallet/SendRequest.java index a706758e6c6..9325de473aa 100644 --- a/core/src/main/java/org/bitcoinj/wallet/SendRequest.java +++ b/core/src/main/java/org/bitcoinj/wallet/SendRequest.java @@ -52,7 +52,7 @@ public class SendRequest { * *If there are already inputs to the transaction, make sure their out point has a connected output, * otherwise their value will be added to fee. Also ensure they are either signed or are spendable by a wallet - * key, otherwise the behavior of {@link Wallet#completeTx(Wallet.SendRequest)} is undefined (likely + * key, otherwise the behavior of {@link Wallet#completeTx(SendRequest)} is undefined (likely * RuntimeException).
*/ public Transaction tx; diff --git a/core/src/main/java/org/bitcoinj/wallet/Wallet.java b/core/src/main/java/org/bitcoinj/wallet/Wallet.java index 044d349df10..29fe173fe47 100644 --- a/core/src/main/java/org/bitcoinj/wallet/Wallet.java +++ b/core/src/main/java/org/bitcoinj/wallet/Wallet.java @@ -3426,7 +3426,7 @@ public void setDescription(String description) { } /** - * Get the description of the wallet. See {@link Wallet#setDescription(String))} + * Get the description of the wallet. See {@link Wallet#setDescription(String)} */ public String getDescription() { return description; @@ -3703,7 +3703,7 @@ public enum MissingSigsMode { USE_DUMMY_SIG, /** * If signature is missing, {@link org.bitcoinj.signers.TransactionSigner.MissingSignatureException} - * will be thrown for P2SH and {@link ECKey.MissingPrivateKeyException} for other tx types. + * will be thrown for P2SH and {@link org.bitcoinj.core.ECKey.MissingPrivateKeyException} for other tx types. */ THROW } @@ -3718,7 +3718,7 @@ public enum MissingSigsMode { * and lets you see the proposed transaction before anything is done with it. * *This is a helper method that is equivalent to using {@link SendRequest#to(Address, Coin)} - * followed by {@link Wallet#completeTx(Wallet.SendRequest)} and returning the requests transaction object. + * followed by {@link Wallet#completeTx(SendRequest)} and returning the requests transaction object. * Note that this means a fee may be automatically added if required, if you want more control over the process, * just do those two steps yourself.
* @@ -3751,7 +3751,7 @@ public Transaction createSend(Address address, Coin value) throws InsufficientMo * Sends coins to the given address but does not broadcast the resulting pending transaction. It is still stored * in the wallet, so when the wallet is added to a {@link PeerGroup} or {@link Peer} the transaction will be * announced to the network. The given {@link SendRequest} is completed first using - * {@link Wallet#completeTx(Wallet.SendRequest)} to make it valid. + * {@link Wallet#completeTx(SendRequest)} to make it valid. * * @return the Transaction that was created * @throws InsufficientMoneyException if the request could not be completed due to not enough balance. @@ -4660,8 +4660,8 @@ public BloomFilter getBloomFilter(double falsePositiveRate) { *This is used to generate a BloomFilter which can be {@link BloomFilter#merge(BloomFilter)}d with another. * It could also be used if you have a specific target for the filter's size.
* - *See the docs for {@link BloomFilter(int, double)} for a brief explanation of anonymity when using bloom - * filters.
+ *See the docs for {@link BloomFilter#BloomFilter(int, double, long, BloomFilter.BloomUpdate)} for a brief explanation of + * anonymity when using bloom filters.
*/ @Override @GuardedBy("keyChainGroupLock") public BloomFilter getBloomFilter(int size, double falsePositiveRate, long nTweak) { diff --git a/core/src/main/java/org/bitcoinj/wallet/WalletProtobufSerializer.java b/core/src/main/java/org/bitcoinj/wallet/WalletProtobufSerializer.java index a698f6df34e..c6ccf9cfc34 100644 --- a/core/src/main/java/org/bitcoinj/wallet/WalletProtobufSerializer.java +++ b/core/src/main/java/org/bitcoinj/wallet/WalletProtobufSerializer.java @@ -398,7 +398,7 @@ public Wallet readWallet(InputStream input, @Nullable WalletExtension... walletE * Wallet object with {@code forceReset} set {@code true}. It won't work. * *If {@code forceReset} is {@code true}, then no transactions are loaded from the wallet, and it is configured - * to replay transactions from the blockchain (as if the wallet had been loaded and {@link Wallet.reset} + * to replay transactions from the blockchain (as if the wallet had been loaded and {@link Wallet#reset()} * had been called immediately thereafter). * *
A wallet can be unreadable for various reasons, such as inability to open the file, corrupt data, internally @@ -447,7 +447,7 @@ public Wallet readWallet(NetworkParameters params, @Nullable WalletExtension[] e * Wallet object with {@code forceReset} set {@code true}. It won't work.
* *If {@code forceReset} is {@code true}, then no transactions are loaded from the wallet, and it is configured - * to replay transactions from the blockchain (as if the wallet had been loaded and {@link Wallet.reset} + * to replay transactions from the blockchain (as if the wallet had been loaded and {@link Wallet#reset()} * had been called immediately thereafter). * *
A wallet can be unreadable for various reasons, such as inability to open the file, corrupt data, internally diff --git a/core/src/main/java/org/bitcoinj/wallet/listeners/WalletCoinsReceivedEventListener.java b/core/src/main/java/org/bitcoinj/wallet/listeners/WalletCoinsReceivedEventListener.java index 3242146af8a..08b0128ff4a 100644 --- a/core/src/main/java/org/bitcoinj/wallet/listeners/WalletCoinsReceivedEventListener.java +++ b/core/src/main/java/org/bitcoinj/wallet/listeners/WalletCoinsReceivedEventListener.java @@ -29,7 +29,7 @@ public interface WalletCoinsReceivedEventListener { * This is called when a transaction is seen that sends coins to this wallet, either because it * was broadcast across the network or because a block was received. If a transaction is seen when it was broadcast, * onCoinsReceived won't be called again when a block containing it is received. If you want to know when such a - * transaction receives its first confirmation, register a {@link TransactionConfidence} event listener using + * transaction receives its first confirmation, register a {@link org.bitcoinj.core.TransactionConfidence} event listener using * the object retrieved via {@link org.bitcoinj.core.Transaction#getConfidence()}. It's safe to modify the * wallet in this callback, for example, by spending the transaction just received. *