Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the blockchain file (as opposed to delete it) in preparation for restore #1702

Closed
wants to merge 1 commit into from

Conversation

oscarguindzberg
Copy link
Contributor

This is an alternative solution to #1695

@schildbach
Copy link
Member

Sounds like a good idea to me!

@schildbach
Copy link
Member

If that solves your problem, I like it more than #1695.

@oscarguindzberg oscarguindzberg changed the title [WIP] Clear block store instead of removing block store file on restore from seed Clear the blockchain file (as opposed to delete it) in preparation for restore Mar 11, 2019
@oscarguindzberg
Copy link
Contributor Author

I just:

  • Removed WalletAppKit.provideBlockStore() and modified WalletAppKit's vStore instance variable type to stress it is of SPVBlockStore type: WalletAppKit won't work with another store type. The "overridable" solution was half-way done. Overriding provideBlockStore() to return any of the other BlockStore implementations included in bitcoinj would make the system fail on restore from seed/key.
  • Rebased from master.
  • Removed "[WIP]" label from the title.

@oscarguindzberg
Copy link
Contributor Author

@schildbach don't forget about this PR :)

@schildbach
Copy link
Member

Thanks for the reminder! I just merged.

@schildbach schildbach closed this Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants