Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 (typescript included) #104

Merged
merged 33 commits into from Apr 3, 2019

Conversation

@d-yokoi
Copy link
Member

d-yokoi commented Mar 23, 2019

This is initial typescript implementation of bip39.

  • Most of the config files are the same with those of bitcoinjs-lib (bitcoinjs/bitcoinjs-lib#1319).
  • There are no changes to exposed interfaces and unit tests.

Edit: By @junderw

  • Typescript implementation
  • Ability to separate wordlists
  • Remove unorm dependency
  • Remove Hex methods
  • Add Async pbkdf2 (default async, offer Sync method too)
d-yokoi added 12 commits Mar 23, 2019
@d-yokoi d-yokoi force-pushed the typescript branch from 0b33cc5 to 834389c Mar 23, 2019
d-yokoi added 5 commits Mar 23, 2019
Copy link
Member

junderw left a comment

Thanks a lot. Change the title when you're finished.

src/ts_src/index.js Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
ts_src/index.ts Outdated Show resolved Hide resolved
test/index.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
d-yokoi added 5 commits Mar 24, 2019
@d-yokoi d-yokoi changed the title wip: initial typescript implementation initial typescript implementation Mar 25, 2019
d-yokoi added 2 commits Mar 25, 2019
ts_src/index.ts Outdated Show resolved Hide resolved
@junderw junderw force-pushed the typescript branch from e895565 to 6dedef0 Mar 26, 2019
@junderw

This comment has been minimized.

Copy link
Member

junderw commented Mar 26, 2019

See also #105

junderw added 5 commits Mar 28, 2019
Allow excluding wordlists when building for browserify
@junderw junderw changed the title initial typescript implementation v3 (typescript included) Apr 2, 2019
@junderw
junderw approved these changes Apr 2, 2019
Copy link
Member

junderw left a comment

This looks good to go. @d-yokoi thoughts?

@d-yokoi

This comment has been minimized.

Copy link
Member Author

d-yokoi commented Apr 2, 2019

@junderw
Thanks for your great work!
I think we are ready to go.

@junderw junderw merged commit cd6bcdb into master Apr 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@d-yokoi d-yokoi deleted the typescript branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.