TransactionBuilder.fromTransaction

[bezreyhan]

I'm running into an interesting issue.

If I add inputs to a TransactionBuilder I do not get any errors. However, when I add inputs to a transaction and then run TransactionBuilder.fromTransaction(tx) I get this error: https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/src/transaction_builder.js#L90

The problem arises here: https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/src/transaction_builder.js#L90

when I console.log the result of classifyInput I get:

 "nonstandard"

Am I doing something incorrectly or is there a bug here? Should we be running classifyOutput instead of classifyInput?

Thanks

[dcousens]

Hey @bezreyhan,

TransactionBuilder is only for building standard transactions at this time, it doesn't support building on top of transactions that have non-standard inputs.
I'm happy to add support for more types if you feel something is necessary.

If you are building highly customized transactions, for now, Transaction (RawTransaction in 2.0.0) is the only available option.

[bezreyhan]

This is is not something I personally need. I was actually just playing around with the library to see how things work.

Although, I'm not sure why the transaction would be labeled "non standard". The inputs are referencing funds that came from a Testnet faucet. I was able to to add the inputs directly to a newly instantiated TransactionBuilder object. The problem came when I tried to add the same inputs to a Transaction object and then created a TransactionBuilder from that transaction.

Here is the code I'm running:

var txHash = "e422acbc206d8da6ee3c5acfd33d4f258100ab677f80dab8a469678c92bad959"
var index = 0
var script = "OP_HASH160 5b100319fc97514cd8cf1d5f546186e161572ceb OP_EQUAL"
var prevOutScript = bitcoin.Script.fromASM(script)

var txb = new TransactionBuilder()
txb.addInput(txHash, index, undefined, prevOutScript)

// Throws an error
var tx = new Transaction()
tx.addInput(txHash, index, undefined, prevOutScript)
txb = TransactionBuilder.fromTransaction(tx)

[dcousens]

@bezreyhan fixed in #329, can you still reproduce?

[bezreyhan]

@dcousens Yup, fixed it.

It hasn't been merged into master yet right? It only worked "txbmerge" but not "master"

Thanks.

[weilu]

No not merged in master yet