Rename Address

[dcousens]

Currently Address is imported as Address around the project, this is in light of it previously being instantiable.

As this is no longer an instantiable object, we should adhere to convention and name it as its lowercase companion.

However, address is a very common variable name, and it would be a bit odd to set that as the convention, so maybe we should make peoples lives easier and rename it here?

Any ideas?

[dcousens]

ping @jprichardson, ideas?
I really hate utilities as a concept (and a name), and it is almost always a code/API smell. But in this case, the OOP-like route is no better.

[jprichardson]

However, address is a very common variable name, and it would be a bit odd to set that as the convention, so maybe we should make peoples lives easier and rename it here.

I think address (lowercase) is fine. Someone could always use addr as a variable instead of address to prevent conflicts.

[dcousens]

@jprichardson I think also its important to remember most people will use the bitcoin namespace anyway.
So, it could be: var myAddress = bitcoin.address.fromOutputScript(script).