ECKey -D test and light cleanup #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
Our use of BigInteger is non-mutating in this instance, so there is no reason in taking a clone initially. (see num = num.multiply(BASE).
Undefined is treated as zero if it ever gets to this point anyway, so no value is added by having this default param here. A test fixture to verify this behaviour is added.
The encode/decode functions are also now similar syntactically.
Contributor
Author
There was a problem hiding this comment.
This will be necessary for parsing Script from binary data. Note it isn't used yet because all that code is currently in-lined inside Script.
Contributor
There was a problem hiding this comment.
Why not adding it only when it's started being used?
Contributor
Author
There was a problem hiding this comment.
Well, in this case, it was more about completing the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small enough PR, just some light fixes and cleanup before I submit the
ScriptandTransactionrefactor's.I'll just inline some comments on the commits for anything not immediately obvious from the commit message.