Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chained on #212.
This pull request moves all the
ecdsaserialize/parse functions toECSignature, a new class interface for importing/exportingECSignatures.The code is straight forward enough, with the test data broken away from
ecdsafixtures, but not altered.ECSignature.fromScriptSignaturewas also added to importDERsignatures with a hashType byte appended on the end. It is up for debate whether this is worthwhile for now. But it will be worthwhile if we instead pass around this object and only encode it when a script signature is made.That is, instead of
createPubKeyScriptSig(DERsignatureBuffer), it is instead:This saves serialization to
DERuntil is necessary, meaning we can allow for easier verification of signatures as an intermediary step.This may not be the best solution, so I'm open for other ideas.
Comparison link: https://github.com/dcousens/bitcoinjs-lib/compare/txclean...ecsignature