Fee and dust #215
Fee and dust #215
Conversation
test/network.js
Outdated
There was a problem hiding this comment.
Can you use the transactions from fixtures/transaction.json instead? I'd prefer to remove mainnet_tx.json if we can.
Or better yet, make test fixtures just for network.
There was a problem hiding this comment.
Fixed in 5dcefc5. I removed its dependency on fixtures entirely and used stubs instead. After all, why should fee estimation care about how transaction is serialized? It assumes tx.toBuffer does its job correctly and produces the correct size.
There was a problem hiding this comment.
Agreed. I think the stubs are a solid approach in this case. Might be a good idea to eventually move the test cases themselves to a more data driven approach though, if possible.
src/networks.js
Outdated
There was a problem hiding this comment.
See #216. If that gets merged, please change dustsofthreshold to dustSoftThreshold
There was a problem hiding this comment.
Done with a rebase, which also cleaned up the commit history
3 participants
This PR 1) fixes the constants used for Bitcoin transaction fees & dust and 2) adds fee estimation for dogecoin and litecoin as an example of how it can be done for alternative networks.