ECKey: adds tests for makeRandom #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test failure is yet again the non-locking faucet propagation problem with helloblock. @locksley @sidazhang any news on a fix for this? |
src/eckey.js
Outdated
Contributor
|
+1 when the |
Contributor
Author
|
Rebased on HEAD. |
Contributor
Author
|
Tests pass, just coveralls crying at the rebase. |
kyledrake
added a commit
that referenced
this pull request
Jun 26, 2014
ECKey: adds tests for makeRandom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for
ECKey.makeRandom, which has previously not been under appropriate test.It uses a stubbed RNG as the
secure-randomRNG is not the focus of this test.secure-randomwas also upgraded to version1.0.0to userandomBuffer.