Skip to content

Conversation

@jeffscottward
Copy link

The stage is set for using Gulp to build minified versions of bitcoinjs-lib.
The repo owner should now publish to bower under the credentials of bitcoinjs-lib.

Please make sure to 'bower init' for the scaffolding, commit/push that, and register it.
See docs here: http://bower.io/docs/creating-packages/

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cddda9e on jeffscottward:master into ca0c56f on bitcoinjs:master.

@weilu
Copy link
Contributor

weilu commented Jul 23, 2014

@jeffscottward what does the gulp script do that the current npm run compile doesn't already do?

@dcousens
Copy link
Contributor

Agreed, why are we including gulp here?

@jeffscottward
Copy link
Author

I'm unaware of npm run compile command available.

As a front-end guy building a bower package for the front-end, I logically use a tool that front-end people are familiar with a nice stream based API.

If you are more privvy to using 'npm run compile' to browserify/uglify then please set that up your self. The bower publishing part of it I've already explained.

However you do compile, just through it into a top level /dist/ as thats best practice with Bower directories.

Thanks

@dcousens
Copy link
Contributor

But, we already have npm run compile... this would be just adding another build system for no gain except enabling some users to use gulp.

@jeffscottward
Copy link
Author

Ok I'm sorry but that is complete bullshit. They shouldn't even be able to
use a library/module if they don't know about a specific build tool? Ok so
then fuck all the jQuery kids then yea?

Get off the high horse dude.
You wanna use npm run compile to deploy, that's FINE. Was just trying to
HELP. You were the one who couldn't even be bothered to look at one page
of documentation on deploying to bower.

Do it or don't. I don't care.
I can just redeploy my version. It's going to Bower and you can't stop it.

On Wednesday, July 23, 2014, Daniel Cousens notifications@github.com
wrote:

But, we already have npm run compile... this would be just adding
another build system for no gain except enabling some users to use bower. npm
run * is not an unfamiliar concept, and I'd really question whether a
developer should use bitcoinjs-lib if they are completely unfamiliar with
a traditional node build process.


Reply to this email directly or view it on GitHub
#245 (comment)
.

Thanks,
Jeff Ward
Front-end Developer
Tel: 516-551-8624
jsward.17@gmail.com jsward.17@gmail.com
@jeffscottward https://twitter.com/#!/jeffscottward

@jprichardson
Copy link
Member

@jeffscottward since you're replying by email, you probably didn't notice that @dcousens revised his comment and removed the statement that probably evoked your hostility.

I think what @weilu and @dcousens are asking is what does gulp scripts (as seen by your PR) do that npm run compile does not do? Since anyone who has gulp installed almost assuredly has npm installed (since npm is required to install gulp) it becomes of a question of what added value does gulp bring in this specific case? I'm a huge fan of gulp btw. I also don't think the bitcoinjs-lib devs are against adding Bower support, they're just having a dialogue on why they should add gulp to the build process for this specific case when adding a bower script to npm (to write to ./dist) in conjunction with npm run compile would work fine.

Hopefully this clears things up.

@weilu
Copy link
Contributor

weilu commented Jul 24, 2014

@jeffscottward chill dude. It's not a npm vs. everything else war. It's just about not reinventing the wheel. I'm actually of the opinion that the bower package should be maintained by someone who actually uses it. Neither @dcousens nor I use bower. I don't think @kyledrake does either, but I understand that he wants to keep it all under the same roof.

Side note, watch your attitude, because you know, we are all gentlemen and ladies here, on high horses of course ;)

img_0177

@weilu weilu closed this Jul 24, 2014
@dcousens
Copy link
Contributor

@jeffscottward sorry if I offended you Jeff, I realised that comment was a bit out of place, so I revised it, completely forgetting that no edit is fast enough to stop the original going to email notifications.

@jprichardson hit the nail on the head in regards to our/my intentions, so hopefully we can resolve this maturely..

@kyledrake
Copy link
Contributor

I would totally burn one with that horse.

I would like to keep the Bower release consistent, because then I can sign it with my PGP key (I'm serving as the distributor key right now, because my key has a lot of trust and commits behind it, which makes it good for this), and we can have a way to make sure that the code being distributed has not been tampered with. If this doesn't happen, hackers can (and probably will) break into Bower's servers, change the code to steal people's money, and there will be absolutely no sane way to verify that this has happened. It is unsafe and irresponsible to distribute code that has not been signed with a PGP key.

I don't understand why Bower requires gulp here, perhaps someone can help me understand this. I've looked at the Bower package guide (http://bower.io/docs/creating-packages/), and I didn't see any mention of gulp there. As far as I understand, what we really need is a bower.json file in the repository, which this PR does not contain. It would be interesting to see if there's a tool to convert a package.json automatically to bower (assuming I understand this correctly?)

Does bower use the git repo to distribute the package, or does it run its own server with packages on it? If it requires a dist file from the git repo, then it's possible that we need to distributed minified file in our repo, which I would rather not do. I would much prefer if users compiled their own, as that guarantees that the file is up-to-date and is inspect-able.

Here's a potential compromise: How about we create a bitcoinjs/bitcoinjs-lib-dist repository, which contains tagged/signed releases of the compiled code and has whatever Bower needs. Is that an okay compromise?

Let's work together on this, and then we can play a friendly game of slow pitch softball afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants