-
Notifications
You must be signed in to change notification settings - Fork 2.2k
add gulp build for bower prep #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jeffscottward what does the gulp script do that the current |
|
Agreed, why are we including |
|
I'm unaware of npm run compile command available. As a front-end guy building a bower package for the front-end, I logically use a tool that front-end people are familiar with a nice stream based API. If you are more privvy to using 'npm run compile' to browserify/uglify then please set that up your self. The bower publishing part of it I've already explained. However you do compile, just through it into a top level /dist/ as thats best practice with Bower directories. Thanks |
|
But, we already have |
|
Ok I'm sorry but that is complete bullshit. They shouldn't even be able to Get off the high horse dude. Do it or don't. I don't care. On Wednesday, July 23, 2014, Daniel Cousens notifications@github.com
Thanks, |
|
@jeffscottward since you're replying by email, you probably didn't notice that @dcousens revised his comment and removed the statement that probably evoked your hostility. I think what @weilu and @dcousens are asking is what does Hopefully this clears things up. |
|
@jeffscottward chill dude. It's not a npm vs. everything else war. It's just about not reinventing the wheel. I'm actually of the opinion that the bower package should be maintained by someone who actually uses it. Neither @dcousens nor I use bower. I don't think @kyledrake does either, but I understand that he wants to keep it all under the same roof. Side note, watch your attitude, because you know, we are all gentlemen and ladies here, on high horses of course ;) |
|
@jeffscottward sorry if I offended you Jeff, I realised that comment was a bit out of place, so I revised it, completely forgetting that no edit is fast enough to stop the original going to email notifications. @jprichardson hit the nail on the head in regards to our/my intentions, so hopefully we can resolve this maturely.. |
|
I would totally burn one with that horse. I would like to keep the Bower release consistent, because then I can sign it with my PGP key (I'm serving as the distributor key right now, because my key has a lot of trust and commits behind it, which makes it good for this), and we can have a way to make sure that the code being distributed has not been tampered with. If this doesn't happen, hackers can (and probably will) break into Bower's servers, change the code to steal people's money, and there will be absolutely no sane way to verify that this has happened. It is unsafe and irresponsible to distribute code that has not been signed with a PGP key. I don't understand why Bower requires gulp here, perhaps someone can help me understand this. I've looked at the Bower package guide (http://bower.io/docs/creating-packages/), and I didn't see any mention of gulp there. As far as I understand, what we really need is a bower.json file in the repository, which this PR does not contain. It would be interesting to see if there's a tool to convert a package.json automatically to bower (assuming I understand this correctly?) Does bower use the git repo to distribute the package, or does it run its own server with packages on it? If it requires a dist file from the git repo, then it's possible that we need to distributed minified file in our repo, which I would rather not do. I would much prefer if users compiled their own, as that guarantees that the file is up-to-date and is inspect-able. Here's a potential compromise: How about we create a bitcoinjs/bitcoinjs-lib-dist repository, which contains tagged/signed releases of the compiled code and has whatever Bower needs. Is that an okay compromise? Let's work together on this, and then we can play a friendly game of slow pitch softball afterwards. |

The stage is set for using Gulp to build minified versions of bitcoinjs-lib.
The repo owner should now publish to bower under the credentials of bitcoinjs-lib.
Please make sure to 'bower init' for the scaffolding, commit/push that, and register it.
See docs here: http://bower.io/docs/creating-packages/