Skip to content

Conversation

@dcousens
Copy link
Contributor

This reduces the browserify build size from 600k to ~300k. While most apps may include crypto anyway, they all fall back to the same modules as this is what crypto uses in browserify.

Not indifferent to using require('inherits') vs require('events').inherit

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.16% when pulling 64e206c on buildreduce into 03f3ccf on master.

@dcousens
Copy link
Contributor Author

Will merge after TRAVIS passes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.16% when pulling b558747 on buildreduce into 03f3ccf on master.

dcousens added a commit that referenced this pull request Mar 19, 2015
crypto: use packages directly
@dcousens dcousens merged commit c66b888 into master Mar 19, 2015
@dcousens dcousens deleted the buildreduce branch March 19, 2015 02:29
@dcousens dcousens mentioned this pull request Mar 25, 2015
Closed
@rubensayshi
Copy link
Contributor

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants