adhere more closely to BIP66 #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @weilu @jprichardson |
Member
|
Since we discussed creating packages that represent BIPs, do you think that it makes sense to turn BIP66 functionality into a package? |
Contributor
Author
|
@jprichardson that sounds like a great idea, however, lets not let it slow down this PR? We can extract it very easily after :) |
Contributor
There was a problem hiding this comment.
Perhaps we should extract all above validation into a function validateDER with reference to bip66?
Contributor
Author
There was a problem hiding this comment.
I will later, in fact I might even pull this out to a bip66 module, that way it could be super clear.
Contributor
|
The implementation looks right to me compared to the reference code. Do we have test case for each one of them though? |
Contributor
Author
|
@weilu we do have test cases for each. |
Closed
dcousens
added a commit
that referenced
this pull request
Sep 14, 2015
dcousens
added a commit
that referenced
this pull request
Sep 14, 2015
dcousens
added a commit
that referenced
this pull request
Sep 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pseudo code for BIP66 here, with ordering amendments.
The constant amendments are because we ignore the SIGHASH byte in this function, which is why the constants are
8, 72for the min/max sizes, and6instead of7for the total length offset.