Various breaking changes #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #439
Addresstoaddress*scriptstoscript- now consistent withaddressecurveby removingECPair.curve(part of Extract ECC operations to 3rd party module #394) ** - breaking change
As part of this, I also start using a
bprefix where ambiguity exists. This was already the case forcrypto, but a few lame ambiguities propped up, and this makes explicitly clear.Most importantly, this problem would rarely occur in user environments as they would be importing as
var bitcoinjs = require('bitcoinjs-lib'), and therefore will already have implicit name spacing.These changes were already implied, so I'm going to merge, but marked as a breaking change for posterity and so I can easily iterate the tagged issues for the CHANGELOG.