Extract BIP66 module #448
Merged
Extract BIP66 module #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
Again, huge performance improvement here. Added tests to cover it, overall script tests running in half the time, isolated benchmark gives >200% improvement.
In terms of validity, this is now on par with bitcoin-core: https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L67-L87
Contributor
Author
|
@weilu please post-ACK |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only breaking change in terms of exact exception messages.
The messages are now consistent in the https://github.com/bitcoinjs/bip66 module, and adhering to SEMVER.
The fact I can now test for all of them using:
/Expected DER (integer|sequence)|(R|S) value (excessively padded|is negative)|(R|S|DER sequence) length is (zero|too short|too long|invalid)/Is a huge bonus compared to the huge regex that was necessary prior.