Skip to content

standard: remove padded Blocks #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2015
Merged

standard: remove padded Blocks #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/ecpair.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ function ECPair (d, Q, options) {
if (Q) throw new TypeError('Unexpected publicKey parameter')

this.d = d

} else {
typeforce(types.ECPoint, Q)

Expand Down
1 change: 0 additions & 1 deletion src/transaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ Transaction.prototype.hashForSignature = function (inIndex, prevOutScript, hashT
input.sequence = 0
}
})

} else if ((hashType & 0x1f) === Transaction.SIGHASH_SINGLE) {
var nOut = inIndex

Expand Down
1 change: 0 additions & 1 deletion test/ecdsa.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ describe('ecdsa', function () {
var signature
if (f.signature) {
signature = ECSignature.fromDER(new Buffer(f.signature, 'hex'))

} else if (f.signatureRaw) {
signature = new ECSignature(new BigInteger(f.signatureRaw.r, 16), new BigInteger(f.signatureRaw.s, 16))
}
Expand Down
1 change: 0 additions & 1 deletion test/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ describe('script', function () {

if (f.scriptSig) {
assert.strictEqual(bscript.toASM(scriptSig), f.scriptSig)

} else {
assert.strictEqual(scriptSig.toString('hex'), f.scriptSigHex)
}
Expand Down
5 changes: 1 addition & 4 deletions test/transaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ describe('Transaction', function () {

if (txIn.data) {
scriptSig = new Buffer(txIn.data, 'hex')

} else if (txIn.script) {
scriptSig = bscript.fromASM(txIn.script)
}
Expand All @@ -31,9 +30,7 @@ describe('Transaction', function () {
var script

if (txOut.data) {
var data = new Buffer(txOut.data, 'hex')
script = data

script = new Buffer(txOut.data, 'hex')
} else if (txOut.script) {
script = bscript.fromASM(txOut.script)
}
Expand Down
5 changes: 1 addition & 4 deletions test/transaction_builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ describe('TransactionBuilder', function () {

if (!sign.throws) {
txb.sign(index, keyPair, redeemScript, sign.hashType)

} else {
assert.throws(function () {
txb.sign(index, keyPair, redeemScript, sign.hashType)
Expand All @@ -229,9 +228,7 @@ describe('TransactionBuilder', function () {
describe('for ' + (f.description || f.exception), function () {
beforeEach(function () {
if (f.txHex) {
var tx = Transaction.fromHex(f.txHex)
txb = TransactionBuilder.fromTransaction(tx)

txb = TransactionBuilder.fromTransaction(Transaction.fromHex(f.txHex))
} else {
txb = construct(f)
}
Expand Down