Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Build Failure #127

Closed
landabaso opened this issue Jul 24, 2023 · 2 comments · Fixed by #128
Closed

Docker Build Failure #127

landabaso opened this issue Jul 24, 2023 · 2 comments · Fixed by #128

Comments

@landabaso
Copy link
Contributor

While attempting to build the Dockerfile (Macos Intel) with docker build -t tiny-secp256k1 ., the build fails on the step to clone and install binaryen:

CMake Error at third_party/CMakeLists.txt:12 (add_library):
Cannot find source file:
googletest/googletest/src/gtest_main.cc

It appears that the Dockerfile is missing the step to initialize and update the googletest submodule. I (GhatGPT, really) could fix it by adding this line into the Dockerfile:

 # Install wasm-opt from binaryen
 RUN git clone --depth 1 --branch version_114 https://github.com/WebAssembly/binaryen.git /binaryen && \
   cd /binaryen && \
+  git submodule update --init && \
   cmake . && \
   make -j$(nproc) && \
   make install && \
@junderw
Copy link
Member

junderw commented Jul 25, 2023

Can you make a PR? Thanks!

@landabaso
Copy link
Contributor Author

Yes, I'm still having issues building the project with Docker. Despite the wasm32-unknown-unknown target seemingly being handled in the Dockerfile, I'm getting a 'target not found' error when running make build. I'll work on fixing these issues and will submit a PR once it's all sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants