From f1a9c3cffe982e271438cdf9041a1a0b3667e01c Mon Sep 17 00:00:00 2001
From: Samuel Dobson <dobsonsa68@gmail.com>
Date: Tue, 20 Apr 2021 19:39:32 +1200
Subject: [PATCH] Add functional test for validateaddress

Github-Pull: #16807
Rebased-From: 3bc568d67537e1725ea0d7472412fe9e4331d01c
---
 test/functional/rpc_validateaddress.py | 88 ++++++++++++++++++++++++++
 test/functional/test_runner.py         |  1 +
 2 files changed, 89 insertions(+)
 create mode 100755 test/functional/rpc_validateaddress.py

diff --git a/test/functional/rpc_validateaddress.py b/test/functional/rpc_validateaddress.py
new file mode 100755
index 0000000000000..40691e15a6f96
--- /dev/null
+++ b/test/functional/rpc_validateaddress.py
@@ -0,0 +1,88 @@
+#!/usr/bin/env python3
+# Copyright (c) 2018-2019 The Bitcoin Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+"""Test the deriveaddresses rpc call."""
+from test_framework.test_framework import BitcoinTestFramework
+from test_framework.util import assert_equal
+
+class ValidateaddressTest(BitcoinTestFramework):
+    def set_test_params(self):
+        self.num_nodes = 1
+
+    def run_test(self):
+        # Valid address
+        address = "bcrt1q049ldschfnwystcqnsvyfpj23mpsg3jcedq9xv"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], True)
+        assert 'error' not in res
+        assert 'error_locations' not in res
+
+        # Valid capitalised address
+        address = "BCRT1QPLMTZKC2XHARPPZDLNPAQL78RSHJ68U33RAH7R"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], True)
+        assert 'error' not in res
+        assert 'error_locations' not in res
+
+        # Address with no '1' separator
+        address = "bcrtq049ldschfnwystcqnsvyfpj23mpsg3jcedq9xv"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], False)
+        assert_equal(res['error'], "Missing separator")
+
+        # Address with no HRP
+        address = "1q049ldschfnwystcqnsvyfpj23mpsg3jcedq9xv"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], False)
+        assert_equal(res['error'], "Invalid HRP or Base58 character in address")
+
+        # Address with an invalid bech32 encoding character
+        address = "bcrt1q04oldschfnwystcqnsvyfpj23mpsg3jcedq9xv"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], False)
+        assert_equal(res['error'], "Invalid Base 32 character")
+        assert_equal(res['error_locations'], [8])
+
+        # Address with one error
+        address = "bcrt1q049edschfnwystcqnsvyfpj23mpsg3jcedq9xv"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], False)
+        assert_equal(res['error_locations'], [9])
+        assert_equal(res['error'], "Invalid checksum")
+
+        # Capitalised address with one error
+        address = "BCRT1QPLMTZKC2XHARPPZDLNPAQL78RSHJ68U32RAH7R"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], False)
+        assert_equal(res['error_locations'], [38])
+        assert_equal(res['error'], "Invalid checksum")
+
+        # Valid multisig address
+        address = "bcrt1qdg3myrgvzw7ml9q0ejxhlkyxm7vl9r56yzkfgvzclrf4hkpx9yfqhpsuks"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], True)
+
+        # Multisig address with 2 errors
+        address = "bcrt1qdg3myrgvzw7ml8q0ejxhlkyxn7vl9r56yzkfgvzclrf4hkpx9yfqhpsuks"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], False)
+        assert_equal(res['error_locations'], [19, 30])
+        assert_equal(res['error'], "Invalid checksum")
+
+        # Address with 2 errors (should be 'bcrt1qax9suht3qv95sw33wavx8crpxduefdrsvgsklx')
+        address = "bcrt1qax9suht3qv95sw33xavx8crpxduefdrsvgsklu"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], False)
+        assert_equal(res['error_locations'], [22, 43])
+        assert_equal(res['error'], "Invalid checksum")
+
+        # Invalid but also too long
+        address = "bcrt1q049edschfnwystcqnsvyfpj23mpsg3jcedq9xv049edschfnwystcqnsvyfpj23mpsg3jcedq9xv049edschfnwystcqnsvyfpj23m"
+        res = self.nodes[0].validateaddress(address)
+        assert_equal(res['isvalid'], False)
+        assert_equal(res['error_locations'], list(range(90, 108)))
+        assert_equal(res['error'], "Bech32 string too long")
+
+if __name__ == '__main__':
+    ValidateaddressTest().main()
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
index 57c3a21007566..d93797a940fe8 100755
--- a/test/functional/test_runner.py
+++ b/test/functional/test_runner.py
@@ -271,6 +271,7 @@
     'mempool_compatibility.py',
     'rpc_deriveaddresses.py',
     'rpc_deriveaddresses.py --usecli',
+    'rpc_validateaddress.py',
     'p2p_ping.py',
     'rpc_scantxoutset.py',
     'feature_logging.py',