Repository navigation
GUI: Changes to adapt to dark mode palettes - #157
Closed
bigshiny90 wants to merge 0 commit into
Closed
bigshiny90 wants to merge 0 commit into
bigshiny90 wants to merge 0 commit into
Conversation
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
3 times, most recently
from
August 7, 2025 01:38
c3e11ed to
f3ba124
Compare
luke-jr
requested changes
Aug 7, 2025
luke-jr
reviewed
Aug 7, 2025
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
2 times, most recently
from
August 7, 2025 11:27
7d4719a to
7283c41
Compare
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
from
August 7, 2025 16:06
7283c41 to
54a9abc
Compare
|
Concept ACK 🤌 |
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
from
August 7, 2025 16:37
54a9abc to
4419475
Compare
|
We should make sure to test these, especially the splash screen stuff on different OSs |
Author
Splash screen tested on Linux and Mac. But generally, yes - should be tested on all OSs wish I had a windows setup to test with. Guess I’ll add that to my todos 😂 |
Author
|
Fully tested on Mac and Linux (arch linux/hyprland). would be nice to have some other flavors of linux though i don't see it being much different, i'm not able to 'live' light/dark mode switch on arch/hyprland. Theming on linux and QT5 is always an adventure. |
Ataraxia009
suggested changes
Aug 8, 2025
luke-jr
requested changes
Aug 8, 2025
luke-jr
left a comment
luke-jr
left a comment
Collaborator
There was a problem hiding this comment.
Each logical change should be a separate commit please
Author
i see. yes, i've been in the habit of squashing commits for PRs. i will change it. |
luke-jr
force-pushed
the
tmp
branch
2 times, most recently
from
August 8, 2025 15:52
c7e8c9c to
e48045d
Compare
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
2 times, most recently
from
August 8, 2025 17:07
746170b to
c4af76d
Compare
Ataraxia009
reviewed
Aug 8, 2025
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
from
August 8, 2025 18:28
c4af76d to
1d253c6
Compare
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
2 times, most recently
from
August 9, 2025 04:56
18dc964 to
3e3c211
Compare
bigshiny90
changed the title
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
from
August 9, 2025 05:20
3e3c211 to
268de94
Compare
luke-jr
requested changes
Aug 9, 2025
luke-jr
left a comment
luke-jr
left a comment
Collaborator
There was a problem hiding this comment.
Commit "GUI/Gitcoingui: Add missing pairing action icon update on palette change" should be changed to "Bugfix: GUI/Bitcoingui: Add missing pairing action icon update on palette change"
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
from
August 9, 2025 06:04
268de94 to
81a8030
Compare
Ataraxia009
reviewed
Aug 9, 2025
|
Tested locally btw in mac, everything works fine |
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
2 times, most recently
from
August 9, 2025 15:30
249beff to
8b8c193
Compare
bigshiny90
force-pushed
the
v29.1-knots-rc1-guifixes
branch
from
August 9, 2025 16:11
8b8c193 to
2c15a20
Compare
luke-jr
force-pushed
the
tmp
branch
10 times, most recently
from
August 23, 2025 19:14
a1b683e to
851028e
Compare
Collaborator
|
Merged in upcoming 29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GUI issues in v29.1-rc1:
Fully tested on macOS and Linux.