Skip to content

add -rejectparasites option#78

Closed
Retropex wants to merge 4 commits intobitcoinknots:26.x-knotsfrom
Retropex:metaprotocol
Closed

add -rejectparasites option#78
Retropex wants to merge 4 commits intobitcoinknots:26.x-knotsfrom
Retropex:metaprotocol

Conversation

@Retropex
Copy link
Copy Markdown

can be considered a part of #64

@Retropex Retropex changed the title add -metaprotocol option add -rejectparasites option May 2, 2024
Comment thread src/init.cpp Outdated
Comment thread src/policy/policy.cpp Outdated
Comment thread src/qt/optionsmodel.cpp Outdated
Comment thread src/qt/optionsmodel.cpp Outdated
Comment thread src/init.cpp Outdated
Comment thread src/policy/policy.cpp Outdated
Comment thread src/qt/optionsdialog.cpp Outdated
Comment thread src/qt/optionsmodel.cpp Outdated
Comment thread src/qt/optionsmodel.h Outdated
Comment thread src/test/fuzz/transaction.cpp Outdated
Comment thread src/policy/policy.cpp Outdated
Comment thread src/validation.cpp Outdated
@luke-jr
Copy link
Copy Markdown
Collaborator

luke-jr commented May 6, 2024

Please split the GUI changes out to a second commit

@Retropex Retropex force-pushed the metaprotocol branch 3 times, most recently from 36c311d to 6e0a060 Compare May 6, 2024 16:20
@Retropex
Copy link
Copy Markdown
Author

Retropex commented May 6, 2024

Please split the GUI changes out to a second commit

done 👍

@Retropex Retropex requested a review from luke-jr May 6, 2024 16:23
Comment thread src/qt/optionsmodel.cpp Outdated
Comment thread src/init.cpp Outdated
Comment thread src/policy/policy.cpp Outdated
Comment thread src/qt/optionsdialog.cpp Outdated
Comment thread src/policy/policy.h Outdated
Comment thread src/policy/policy.cpp Outdated
Comment thread src/policy/policy.cpp Outdated
Comment thread src/policy/policy.h Outdated
Comment thread src/init.cpp Outdated
@Retropex
Copy link
Copy Markdown
Author

Retropex commented May 8, 2024

My bad, don't mind this force push, I will change it.

Retropex and others added 2 commits May 8, 2024 22:15
Co-authored-by: Luke Dashjr <luke_github1@dashjr.org>
@Retropex
Copy link
Copy Markdown
Author

Retropex commented May 8, 2024

should be good

@Retropex
Copy link
Copy Markdown
Author

Retropex commented May 9, 2024

I have added tests lets me know if it's enough

@Retropex
Copy link
Copy Markdown
Author

Merged in this commit: 1c1fcdb

@Retropex Retropex closed this May 14, 2024
@luke-jr luke-jr added the merged label Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants