Repository navigation
uart link - #558
Merged
Merged
uart link#558
Conversation
Contributor
|
Hi! From the first sight this looks good but we would need to check if this works properly, which we will try to verify this week. Is there a reason why the CRTP through usb or crazyradio does not work out for you? |
Contributor
Author
|
Hello Kimberly,
I am from the team of the Saarland University that extended the Drone
for Wifi communication with the Raspberry Pi, thus we needed Uart to the
Raspberry Pi.
I am still struggeling with the toolbelt for the Crazyflie library,
otherwise I would already have created a pull request for this one too
and send you an Mail with further information.
Probably it makes sense to wait with the review till you also have this
counterpart, I hope to get it done today or tomorrow.
Best regards,
Marlene
|
Contributor
|
Code looks good and is all behind a build flag so it is not really affecting anybody else using it. A small word of concern is that, with the flag on, communication via the crazyradio is not possible anymore. For the USB and Radiolink, there is an automatic switch, which would be nice to implement the uart in there as well. But we will consider this as a possible future improvement, and it is all safely behind a build flag anyway :) |
cafeciaojoe
pushed a commit
to cafeciaojoe/crazyflie-firmware
that referenced
this pull request
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable CRTP communication via Uart.