log(swift): add more init logging for fatal issues #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added additional 'failure' states for report initialization and explicitly ignore simulators with a message
kattrali
force-pushed
the
dfuller/increase-issue-reporter-logging
branch
from
ea459a8 to
237e4d8
Compare
kattrali
commented
Jun 4, 2025
| return | ||
| } | ||
|
|
||
| issueReporterInitResult = measureTime { |
Contributor
Author
There was a problem hiding this comment.
moved this to the top level instead of nested in the individual types
| } | ||
|
|
||
| issueReporterInitResult = (.initializing, 0) | ||
| guard let outputDir = Logger.reportCollectionDirectory() else { |
Contributor
Author
There was a problem hiding this comment.
This was a check at different places within both type logic branches, so we can instead have one check at the beginning
kstenerud
approved these changes
Jun 4, 2025
FranAguilera
approved these changes
Jun 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added additional 'failure' states for report initialization and explicitly ignore simulators with a message
This is a largely internal change to assist with debugging the initialization of fatal issue reporting uncovered this week