Skip to content

[Android] Revert Native processing parsing #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

[Android] Revert Native processing parsing #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ...ture/src/main/kotlin/io/bitdrift/capture/reports/processor/FatalIssueReporterProcessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,8 @@ internal class FatalIssueReporterProcessor(
}

ReportType.NativeCrash -> {
NativeCrashProcessor.process(
builder,
sdk,
appMetrics,
deviceMetrics,
description,
traceInputStream,
)
// TODO(FranAguilera): BIT-5823 use NativeCrashProcessor once async processing is ready
null
}

else -> null
Expand Down
4 changes: 3 additions & 1 deletion platform/jvm/capture/src/test/kotlin/io/bitdrift/capture/FatalIssueReporterProcessorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import io.bitdrift.capture.reports.persistence.IFatalIssueReporterStorage
import io.bitdrift.capture.reports.processor.FatalIssueReporterProcessor
import org.assertj.core.api.Assertions.assertThat
import org.junit.Before
import org.junit.Ignore
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
Expand Down Expand Up @@ -85,7 +86,7 @@ class FatalIssueReporterProcessorTest {
"persistJvmCrash_withFakeException_shouldCreateNonEmptyErrorModel",
)
assertThat(error.stackTrace(0)!!.sourceFile!!.path).isEqualTo("FatalIssueReporterProcessorTest.kt")
assertThat(error.stackTrace(0)!!.sourceFile!!.line).isEqualTo(58)
assertThat(error.stackTrace(0)!!.sourceFile!!.line).isEqualTo(59)
assertThat(error.stackTrace(0)!!.sourceFile!!.column).isEqualTo(0)
}

Expand Down Expand Up @@ -319,6 +320,7 @@ class FatalIssueReporterProcessorTest {
)
}

@Ignore("TODO(FranAguilera): BIT-5823 use NativeCrashProcessor once async processing is ready")
@Test
fun persistAppExitReport_whenNativeCrash_shouldCreateEmptyErrorModel() {
val description = "Native crash"
Expand Down
Loading