Small optimization in LoggerImpl.extractFields #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyricau
commented
Jul 28, 2025
| put("_error_details", it.message.orEmpty()) | ||
| ): InternalFieldsMap { | ||
| // Maintainer note: keep initialCapacity in sync with the code adding fields to the map. | ||
| val initialCapacity = (fields?.size ?: 0) + (throwable?.let { 2 } ?: 0) |
Contributor
Author
There was a problem hiding this comment.
note: the 2 here has to be kept in sync with the code in throwable?.let {}. That's slightly annoying, an alternative could be:
companion object {
val throwableExtractors = listOf<(Throwable) -> Pair<String, FieldValue>>({
"_error" to it.javaClass.name.orEmpty().toFieldValue()
}, {
"_error_details" to it.message.orEmpty().toFieldValue()
})
}then:
val initialCapacity = (fields?.size ?: 0) + (throwable?.let { throwableExtractors.size } ?: 0)
throwable?.let {
for (extractor in throwableExtractors) {
val (key, value) = extractor(throwable)
extractedFields[key] = value
}
Contributor
There was a problem hiding this comment.
I like this alternative better over the hardcoded 2. The one relying on 2 feels fragile over time and easy to forget if there is a need to add another _error_... fields in the future, though no sure it's worth the cost for creating throwableExtractors
FranAguilera
force-pushed
the
py/optimize_extract_fields
branch
from
97be702 to
47ab3b9
Compare
| @Suppress("SENSELESS_COMPARISON") | ||
| internal fun Map<String, String>?.toFields(): Map<String, FieldValue> { | ||
| if (this == null) return emptyMap() | ||
| if (isNullOrEmpty()) return emptyMap() |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
FranAguilera
force-pushed
the
py/optimize_extract_fields
branch
from
47ab3b9 to
02cc7be
Compare
- In `LoggerImpl.extractFields`, skip creating a MapBuilder (capacity 8) and a HashMap(0S if throwable is null and fields is null or empty - In `LoggerImpl.extractFields`, skip creating a MapBuilder AND a HashMap for every log with fields, directly create the target HashMap with the right capacity. - In `Map.toFields()`, skip creating a HashMap(0) is map is empty.
FranAguilera
force-pushed
the
py/optimize_extract_fields
branch
from
02cc7be to
485dedb
Compare
FranAguilera
approved these changes
Jul 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggerImpl.extractFields, skip creating a MapBuilder (capacity 8) and a HashMap(0) if throwable is null and fields is null or emptyLoggerImpl.extractFields, skip creating a MapBuilder AND a HashMap for every log with fields, directly create the target HashMap with the right capacity.Map.toFields(), skip creating a HashMap(0) is map is empty.