Skip to content

Conversation

@mattklein123
Copy link
Contributor

  1. "workflows.state_periodic_write_interval_ms": This flag is redundant
    as we do periodic persistence processing on every log processed and
    logs are received frequently.
  2. "workflows.traversals_global_count_limit": With the removal of
    parallel execution mode this flag doesn't provide a lot of value and
    removing it cleans up a lot of complexity.

Also clean up some metrics that I don't think provide any real operational value.

1) "workflows.state_periodic_write_interval_ms": This flag is redundant
   as we do periodic persistence processing on every log processed and
   logs are received frequently.
1) "workflows.traversals_global_count_limit": With the removal of
   parallel execution mode this flag doesn't provide a lot of value and
   removing it cleans up a lot of complexity.

Also clean up some metrics that I don't think provide any real
operational value.

Signed-off-by: Matt Klein <mklein@bitdrift.io>
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the metrics might have had some test value to make sure that run management was done as expected, not sure if this costs us some test assertion value. Would be a painful audit process to tell for sure, might not be worth it

@mattklein123
Copy link
Contributor Author

I think some of the metrics might have had some test value to make sure that run management was done as expected, not sure if this costs us some test assertion value. Would be a painful audit process to tell for sure, might not be worth it

Yeah I thought about this. I agree it would be incredibly painful. I think in many cases it is covered by looking at the active workflow states, but possibly not 100%. I can go back and try to check if there are places that don't have further active state checks and try to add them.

Signed-off-by: Matt Klein <mklein@bitdrift.io>
Signed-off-by: Matt Klein <mklein@bitdrift.io>
@mattklein123 mattklein123 merged commit e1594f3 into main Jun 30, 2025
5 checks passed
@mattklein123 mattklein123 deleted the cleanup branch June 30, 2025 19:21
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants