Skip to content

Conversation

@bitfaster
Copy link
Owner

@bitfaster bitfaster commented Dec 5, 2022

Appears that the CoverletOutput parameter is ignored on MacOS, after fixing the path can see that other params (e.g. CoverletOutputFormat are also ignored).

image

Results in this output:

Calculating coverage result...
  Generating report '/Users/runner/work/BitFaster.Caching/BitFaster.Caching/BitFaster.Caching.UnitTests/coverage.json'

But on Windows with the same CoverletOutput parameter, logs reflect this:

Calculating coverage result...
  Generating report 'TestResults\coverage.info'

Workarounds:

  1. Hard code to expected path observed in runner logs
  2. Add explicit properties to the csproj to control CollectCoverage and CoverletOutputFormat

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.611% when pulling 43420b7 on users/alexpeck/maccover into f8627c9 on main.

@bitfaster bitfaster marked this pull request as ready for review December 5, 2022 22:04
@bitfaster bitfaster merged commit 6182959 into main Dec 5, 2022
@bitfaster bitfaster deleted the users/alexpeck/maccover branch December 5, 2022 22:05
bitfaster added a commit that referenced this pull request Jan 6, 2023
bitfaster added a commit that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants