Skip to content

ClassicLru supports value factory arg #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

ClassicLru supports value factory arg #348

merged 1 commit into from
Apr 26, 2023

Conversation

@bitfaster
Copy link
Owner

@bitfaster bitfaster commented Apr 26, 2023

To add the method V GetOrAdd<TArg>(K key, Func<K, TArg, V> valueFactory, TArg factoryArgument) to ICache, all implementations must have this method. Implement for ClassicLru.

@coveralls
Copy link

coveralls commented Apr 26, 2023

Coverage Status

Coverage: 96.111% (-0.4%) from 96.548% when pulling 6e7fd8a on users/alexpeck/classicarg into 8465588 on main.

@bitfaster bitfaster changed the title classic arg ClassicLru supports value factory arg Apr 26, 2023
@bitfaster bitfaster merged commit 60cfc64 into main Apr 26, 2023
@bitfaster bitfaster deleted the users/alexpeck/classicarg branch April 26, 2023 00:31
@bitfaster bitfaster linked an issue Apr 28, 2023 that may be closed by this pull request
[Feature request] Allow to pass additional factory argument to the GetOrAdd/GetOrAddAsync cache methods #311
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature request] Allow to pass additional factory argument to the GetOrAdd/GetOrAddAsync cache methods

3 participants

@bitfaster @coveralls