Fix LRU clear when warm/hot items are touched #453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When items are touched, they are moved to warm by cycling. The Clear() logic naively attempted to cycle the queues n times, where n is the number of items in the cache. Any items that were touched would be cycled to warm, and would fail to be removed.
Fix summary:
Clear()logic to call intoTrimLiveItems(), which tracks how many items have been removed.TrimLiveItems()to take this into account.Trim()andClear()that verify touched items are removed correctly.