Skip to content

Fix code analysis warnings #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Fix code analysis warnings #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26b90ac
fix
Dec 4, 2023
a3d0a17
config await
Dec 4, 2023
328e306
Merge branch 'main' into users/alexpeck/codeanalysis2
bitfaster Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BitFaster.Caching/Lfu/ConcurrentLfu.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ private void DrainBuffers()
public Optional<ICacheMetrics> Metrics => core.Metrics;

///<inheritdoc/>
public Optional<ICacheEvents<K, V>> Events => core.Events;
public Optional<ICacheEvents<K, V>> Events => Optional<ICacheEvents<K, V>>.None();

///<inheritdoc/>
public CachePolicy Policy => core.Policy;
Expand Down
2 changes: 0 additions & 2 deletions BitFaster.Caching/Lfu/ConcurrentLfuCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ public ConcurrentLfuCore(int concurrencyLevel, int capacity, IScheduler schedule

public Optional<ICacheMetrics> Metrics => new(this.metrics);

public Optional<ICacheEvents<K, V>> Events => Optional<ICacheEvents<K, V>>.None();

public CachePolicy Policy => new(new Optional<IBoundedPolicy>(this), Optional<ITimePolicy>.None());

public ICollection<K> Keys => this.dictionary.Keys;
Expand Down
2 changes: 1 addition & 1 deletion BitFaster.Caching/Scheduler/BackgroundThreadScheduler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public sealed class BackgroundThreadScheduler : IScheduler, IDisposable
public BackgroundThreadScheduler()
{
// dedicated thread
Task.Factory.StartNew(() => Background(), cts.Token, TaskCreationOptions.LongRunning, TaskScheduler.Default);
_ = Task.Factory.StartNew(async () => await Background().ConfigureAwait(false), cts.Token, TaskCreationOptions.LongRunning, TaskScheduler.Default);
}

///<inheritdoc/>
Expand Down