From e2573959bf9542a4e97b71f4ab6b0918d2a98129 Mon Sep 17 00:00:00 2001 From: Rama McIntosh Date: Fri, 7 Nov 2025 02:16:20 -1000 Subject: [PATCH 1/2] bump dependencies, including to mysql2 --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 2de48a9..8b5430d 100644 --- a/package.json +++ b/package.json @@ -19,13 +19,13 @@ ], "dependencies": { "@bitfinex/lib-js-util-promise": "git+https://github.com/bitfinexcom/lib-js-util-promise.git", - "async": "^3.2.1", + "async": "^3.2.6", "bfx-facs-base": "git+https://github.com/bitfinexcom/bfx-facs-base.git", "lodash": "^4.17.21", - "mysql": "^2.18.1" + "mysql2": "^3.15.3" }, "engine": { - "node": ">=8.0" + "node": ">=18.0" }, "license": "Apache-2.0", "repository": { From 0f39b4d3e7ec080f7053e7df16fe8202a7de27e6 Mon Sep 17 00:00:00 2001 From: Rama McIntosh Date: Fri, 7 Nov 2025 02:46:06 -1000 Subject: [PATCH 2/2] switch to mysql2 --- index.js | 2 +- test/unit.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/index.js b/index.js index b1f50dc..25fab49 100644 --- a/index.js +++ b/index.js @@ -2,7 +2,7 @@ const async = require('async') const _ = require('lodash') -const mysql = require('mysql') +const mysql = require('mysql2') const Base = require('bfx-facs-base') const { promisify } = require('util') const { promiseFlat } = require('@bitfinex/lib-js-util-promise') diff --git a/test/unit.js b/test/unit.js index 6da399e..d1fb0dd 100644 --- a/test/unit.js +++ b/test/unit.js @@ -464,7 +464,7 @@ describe('DbFacility tests', () => { await sleep(1000) calls = spy.getCalls().map(x => x.args) resultCalls = calls.filter(x => x[0] === 'result') - closeCalls = calls.filter(x => x[0] === 'close') + closeCalls = calls.filter(x => x[0] === 'finish') spy.restore()