[Response] extract href resolving logic #134
Merged
+99
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move href resolving logic to a separate method `resolveHref` - Add unit tests for `resolveHref` in `ResponseParserTest`
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts the href resolving logic from the parseResponse method into a separate resolveHref method to improve testability and maintainability. The refactoring also adds error handling for URL parsing exceptions.
- Extracted href resolution logic to a dedicated
resolveHrefmethod marked with@VisibleForTesting - Added exception handling for
URLParserExceptionwith logging - Created comprehensive unit tests covering absolute URLs, absolute paths, relative paths, and relative paths with colons
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/kotlin/at/bitfire/dav4jvm/ktor/ResponseParser.kt | Extracted href resolving logic to resolveHref method; added error handling and logging for URL parsing failures |
| src/test/kotlin/at/bitfire/dav4jvm/ktor/ResponseParserTest.kt | Added unit tests for the resolveHref method covering various URL formats |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveHrefresolveHrefinResponseParserTest