SupportedReportSet: use Property.Name
#135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change type of reports from Set<String> to Set<Property.Name> - Update parsing logic to handle Property.Name objects
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the SupportedReportSet WebDAV property to use the strongly-typed Property.Name class instead of plain strings for representing report types. This aligns with the existing pattern used by similar properties like ResourceType.
Key changes:
- Changed the
reportsfield type fromSet<String>toSet<Property.Name>for better type safety and consistency with the codebase - Simplified XML parsing logic by removing TEXT handling and keeping only START_TAG parsing, as WebDAV report types are always qualified XML element names (namespace + local name)
- Removed the string concatenation logic that previously constructed report identifiers as
"${namespace}${name}"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.