Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling period durations of days with T suffix #80

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

ArnyminerZ
Copy link
Member

Closes #77

Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
@ArnyminerZ ArnyminerZ added the bug Something isn't working label Feb 7, 2023
@ArnyminerZ ArnyminerZ self-assigned this Feb 7, 2023
@ArnyminerZ ArnyminerZ linked an issue Feb 7, 2023 that may be closed by this pull request
@ArnyminerZ ArnyminerZ marked this pull request as ready for review February 7, 2023 09:53
@rfc2822 rfc2822 requested a review from sunkup February 7, 2023 13:20
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :)

Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@rfc2822 rfc2822 merged commit 1c6bcb3 into main Feb 8, 2023
@rfc2822 rfc2822 deleted the 77-handling-period-durations-of-days-with-t-prefix branch February 8, 2023 10:01
@devvv4ever
Copy link
Member

@ArnyminerZ Didn't this fix make it to 2.1.1? The original URL is still unable to be parsed with the "Text cannot be parsed to a Duration" exception...

@ArnyminerZ
Copy link
Member Author

@rfc2822 would tell better, but I think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling period durations of days with T prefix
4 participants