Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upLibrary evaluation tracking issue #80
Comments
This comment has been minimized.
This comment has been minimized.
|
cc @rust-lang-nursery/libs |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Should we hold off on 1.0 until the crate is converted to use associated constants (#24)? The discussion in rust-lang/rust#29646 seems to be tending towards stabilizing them soon. |
This comment has been minimized.
This comment has been minimized.
sfackler
commented
Mar 31, 2017
|
I would love associated constants for bitflags, so I'd vote for yes if it looks like that'll be landing. |
This comment has been minimized.
This comment has been minimized.
|
That would make bitflags incompatible with quite recent rust's right? That seems kinda undesirable. |
This comment has been minimized.
This comment has been minimized.
sfackler
commented
Apr 7, 2017
|
It'd obviously require a major version bump on bitflags, but the ergonomic benefits of not having a bunch of random constants of different types thrown into the root module is pretty huge. |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
All issues are completed. The library is ready to be evaluated. |
This comment has been minimized.
This comment has been minimized.
|
Is it in any way problematic to release a bitflags 2.0 soon after it incorporates associated consts? If so, I would prefer to wait for associated consts support before 1.0. |
This comment has been minimized.
This comment has been minimized.
|
We might also want to consider #72, since Then again, this could also be supported in bitflags 2.0. |
This comment has been minimized.
This comment has been minimized.
theduke
commented
May 12, 2017
|
Since associated constants are in FCP for stabilization, I'd rather wait a bit longer for a |
This comment has been minimized.
This comment has been minimized.
|
Wow thanks @opilar @crumblingstatue @theduke ! |
This comment has been minimized.
This comment has been minimized.
|
1.0 published! |
alexcrichton
closed this
Sep 9, 2017
This comment has been minimized.
This comment has been minimized.
robinst
commented
Sep 28, 2017
|
Yay! @alexcrichton could you add release notes for 1.0.0 here?: https://github.com/rust-lang-nursery/bitflags/releases (see #121) |
brson commentedMar 16, 2017
•
edited by alexcrichton
This is the tracking issue for the evaluation performed by the libs team last week.