Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows empty flag definition #225

Merged
merged 2 commits into from May 16, 2021
Merged

Allows empty flag definition #225

merged 2 commits into from May 16, 2021

Conversation

thiagoarrais
Copy link

@thiagoarrais thiagoarrais commented Oct 1, 2020

Fixes #179

Please keep in mind I'm kind of a Rust newbie and even more of a Rust macro newbie. I'm not sure this is more convoluted than necessary.

@thiagoarrais
Copy link
Author

thiagoarrais commented Oct 1, 2020

CI failures seem unrelated as they also happen on the main branch.

Maybe #216 fixes them?

@KodrAus
Copy link
Member

KodrAus commented Jan 8, 2021

Thanks @thiagoarrais! Would you like to try rebasing on the current master and see if we end up in a green state again?

@thiagoarrais
Copy link
Author

thiagoarrais commented Jan 12, 2021

Rebased and we're back to green.

@thiagoarrais
Copy link
Author

thiagoarrais commented Mar 26, 2021

Hey, @KodrAus, any blockers here?

@KodrAus
Copy link
Member

KodrAus commented May 11, 2021

Thanks for pushing through this @thiagoarrais. I had a bit of a break from things but am taking a look through now. It looks like we've ended up with another conflict, so I'll take a look through here to save you the trouble and get this in 🙇

@KodrAus KodrAus merged commit ec76dd2 into bitflags:master May 16, 2021
6 checks passed
@KodrAus KodrAus mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty bitflags definitions fail to parse
2 participants