Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making crate accessible from std #227

Merged
merged 2 commits into from Nov 6, 2020

Conversation

raoulstrackx
Copy link
Contributor

@raoulstrackx raoulstrackx commented Oct 13, 2020

Changing dependencies to enable the crate to be used from inside the rust standard library.

see https://github.com/rust-lang/rust/tree/master/library/rustc-std-workspace-core

cc: @jethrogb

@raoulstrackx
Copy link
Contributor Author

raoulstrackx commented Nov 5, 2020

@alexcrichton could this get a review?
All build jobs pass, except for the rust 1.20 compiler.That one fails with no matching package named corefound (required bybitflags). Presumably that compiler is too old to make it compatible to include it in std. Note that that compiler is from 2017-08-27, so over 3 years old.

@alexcrichton
Copy link
Contributor

alexcrichton commented Nov 6, 2020

Sorry but I do not maintain this crate.

@jethrogb
Copy link

jethrogb commented Nov 6, 2020

You're still listed as a crate owner on crates.io

KodrAus
KodrAus approved these changes Nov 6, 2020
Copy link
Member

@KodrAus KodrAus left a comment

This looks good to me!

@KodrAus KodrAus merged commit 080e9ed into bitflags:master Nov 6, 2020
1 check failed
@raoulstrackx
Copy link
Contributor Author

raoulstrackx commented Nov 9, 2020

Thanks for merging! Could you also publish the changes to crates.io? Thanks!

@raoulstrackx
Copy link
Contributor Author

raoulstrackx commented Apr 1, 2021

@KodrAus Could you please publish these changes on crates.io as well? Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants