Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make from_bits a const fn #229

Merged
merged 1 commit into from May 11, 2021
Merged

Make from_bits a const fn #229

merged 1 commit into from May 11, 2021

Conversation

bprosnitz
Copy link
Contributor

@bprosnitz bprosnitz commented Oct 19, 2020

'if' now works in 'const fn as of rust 1.4.6 (https://blog.rust-lang.org/2020/08/27/Rust-1.46.0.html).

I would love to have 'from_bits' be a 'const fn' because it is the safest from_* function.

'if' now works in 'const fn as of rust 1.4.6 (https://blog.rust-lang.org/2020/08/27/Rust-1.46.0.html).

I would love to have 'from_bits' be a 'const fn' because it is the safest from_* function.
@KodrAus
Copy link
Member

KodrAus commented Nov 14, 2020

This looks good to me!

@bprosnitz would you like to rebase this on master to bring in some CI fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants