Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression & simplify tests #247

Merged
merged 2 commits into from Aug 3, 2021
Merged

Conversation

konsumlamm
Copy link
Contributor

@konsumlamm konsumlamm commented Jul 19, 2021

This fixes a regression introduced in #246 (see #246 (comment)), by reverting the specific change, along with adding a test case.

I also took the opportunity to move the tests in test_suite back into the crate tests (instead of having a workspace with a test_suite crate). AFAICT, this happened because it needed extra features that shouldn't leak, but that isn't the case anymore. This makes it easier to run the tests (just cargo test in the main directory).

I also removed appveyor.yml from the exclude list in Cargo.toml, I'm not sure why it was there in the first place though.

@KodrAus
Copy link
Member

KodrAus commented Aug 3, 2021

Ah nicely spotted! And thanks for improving the integration tests too 🙇

@KodrAus KodrAus merged commit 195bf05 into bitflags:master Aug 3, 2021
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants