Add missing tests of BitButtonGroup component (#11646)

[msynk]

closes #11646

Summary by CodeRabbit

• Tests
  • Added comprehensive test coverage for the BitButtonGroup component, including rendering of items, click event handling, and toggle functionality with default state management.

[coderabbitai]

Walkthrough

A new test class BitButtonGroupTests is added with three comprehensive unit tests covering component rendering, item click handling, and toggle state management for the BitButtonGroup component.

Changes

Cohort / File(s)	Change Summary
BitButtonGroup Component Tests src/BlazorUI/Bit.BlazorUI.Tests/Components/Buttons/BitButtonGroupTests.cs	Adds new test class with three tests: BitButtonGroupShouldRenderItemsFromItemsParameter (verifies item rendering and text), BitButtonGroupShouldInvokeOnItemClickAndItemOnClickAction (verifies callback and item-level action invocation), BitButtonGroupToggleDefaultKeyShouldSetToggledItemAndRaiseOnToggleChange (verifies toggle behavior with default key and state change callback)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

This is a straightforward test addition with three well-defined test cases covering documented functionality. The tests follow standard patterns for component testing and validate existing features rather than introducing new logic.

Poem

🐰 A rabbit hops through test code bright,
Clicking buttons left and right,
Toggles dance and items render true,
BitButtonGroup tests—now complete, it's new! 🎯

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding missing tests for the BitButtonGroup component, which matches the actual changeset.
Linked Issues check	✅ Passed	The PR adds comprehensive tests for BitButtonGroup component covering rendering, callbacks, and toggle behavior, which directly addresses the objective to add missing test coverage for BitButtonGroup [#11646].
Out of Scope Changes check	✅ Passed	All changes are limited to adding a new test file for BitButtonGroup with no modifications to production code or unrelated components, staying within the scope of #11646.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide custom instructions to shape the summary (bullet lists, tables, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/BlazorUI/Bit.BlazorUI.Tests/Components/Buttons/BitButtonGroupTests.cs (2)

48-51: Consider using more explicit button selection.

While Find(".bit-btg-itm") works, using FindAll(".bit-btg-itm")[0] or FindAll("button")[0] would make it more explicit that you're testing the first button.

Apply this diff for clarity:

-        var btn = component.Find(".bit-btg-itm");
+        var btn = component.FindAll(".bit-btg-itm")[0];
         Assert.IsNotNull(btn);

---

80-82: Use exact assertion for toggled button count.

In a single-toggle scenario, there should be exactly one toggled button. Using >= 1 is too permissive and might miss bugs where multiple buttons are incorrectly toggled.

Apply this diff:

         var toggled = comp.FindAll(".bit-btg-chk");
-        Assert.IsTrue(toggled.Count >= 1);
+        Assert.AreEqual(1, toggled.Count);
         Assert.IsTrue(toggled[0].TextContent.Contains("B"));

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between c0a0d0a and a287b9a.

📒 Files selected for processing (1)

• src/BlazorUI/Bit.BlazorUI.Tests/Components/Buttons/BitButtonGroupTests.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build and test

🔇 Additional comments (2)

src/BlazorUI/Bit.BlazorUI.Tests/Components/Buttons/BitButtonGroupTests.cs (2)

10-28: LGTM! Clean rendering test.

The test correctly verifies that items are rendered as buttons with the expected text content.

---

76-77: The original review comment is based on a misunderstanding of the component's intended behavior.

The OnInitializedAsync method calls UpdateItemToggle when DefaultToggleKey is set during initialization, and UpdateItemToggle invokes OnToggleChange. This is intentional design, not a bug or unusual behavior. The component is designed to trigger OnToggleChange callbacks both during initialization (when DefaultToggleKey is applied) and on user interaction. The test correctly validates this expected behavior, and the demo pages document this usage pattern as part of the public API.

The test code at lines 76-77 is correct and requires no changes.