From 138cc5a77f6d8ed8a6a8469a06cba0564edb4c3f Mon Sep 17 00:00:00 2001 From: "FUJI Goro (gfx)" Date: Mon, 27 Nov 2017 12:27:32 +0900 Subject: [PATCH 1/3] enable FOOTNOTES available in commonmarker v0.17.6 --- lib/mato/config.rb | 1 + test/mato_test.rb | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/lib/mato/config.rb b/lib/mato/config.rb index 315f122..8e51d3a 100644 --- a/lib/mato/config.rb +++ b/lib/mato/config.rb @@ -10,6 +10,7 @@ class Config DEFAULT_MARKDOWN_PARSE_OPTIONS = %i[ DEFAULT VALIDATE_UTF8 + FOOTNOTES ].freeze # https://github.com/gjtorikian/commonmarker#render-options diff --git a/test/mato_test.rb b/test/mato_test.rb index 5547e43..4e0fdd9 100644 --- a/test/mato_test.rb +++ b/test/mato_test.rb @@ -42,4 +42,27 @@ def test_apply_html_filters new_doc.render_html == "

Hi!

\n" end end + + def test_footnotes + doc = mato.process(<<~MARKDOWN) + This is some text.[^1]. Other text.[^footnote]. + + [^other-note]: Hi! + + [^1]: Some *bolded* footnote definition. + MARKDOWN + + assert do + doc.render_html == <<~'HTML' +

This is some text.[1]. Other text.[^footnote].

+
+
    +
  1. +

    Some bolded footnote definition.

    +
  2. +
+
+ HTML + end + end end From b8b7fa6a5386e43167c2e0ce7e2fb1ea13f35d07 Mon Sep 17 00:00:00 2001 From: "FUJI Goro (gfx)" Date: Mon, 27 Nov 2017 12:29:05 +0900 Subject: [PATCH 2/3] requires commonmarker v0.17.6 for footnotes --- mato.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mato.gemspec b/mato.gemspec index f4b563c..409b5db 100644 --- a/mato.gemspec +++ b/mato.gemspec @@ -23,6 +23,6 @@ Gem::Specification.new do |spec| spec.required_ruby_version = ">= 2.3" spec.add_runtime_dependency "nokogiri", ">= 1.6" - spec.add_runtime_dependency "commonmarker", ">= 0.14" + spec.add_runtime_dependency "commonmarker", ">= 0.17.6" spec.add_runtime_dependency "rouge", ">= 3.0.0" end From 7c25b109d3923ea6a4e01a84bcdbafbafcb7fd3b Mon Sep 17 00:00:00 2001 From: "FUJI Goro (gfx)" Date: Mon, 27 Nov 2017 12:34:43 +0900 Subject: [PATCH 3/3] fix for rubocop --- Gemfile | 1 + mato.gemspec | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index e11d7d2..02081c2 100644 --- a/Gemfile +++ b/Gemfile @@ -12,3 +12,4 @@ gem "m" gem "minitest" gem "minitest-power_assert" gem "rake", ">= 10.0" +gem "rubocop" diff --git a/mato.gemspec b/mato.gemspec index 409b5db..e6c0918 100644 --- a/mato.gemspec +++ b/mato.gemspec @@ -22,7 +22,7 @@ Gem::Specification.new do |spec| spec.required_ruby_version = ">= 2.3" - spec.add_runtime_dependency "nokogiri", ">= 1.6" spec.add_runtime_dependency "commonmarker", ">= 0.17.6" + spec.add_runtime_dependency "nokogiri", ">= 1.6" spec.add_runtime_dependency "rouge", ">= 3.0.0" end