add error handling for session token retrieval #3

Merged
merged 1 commit into from Mar 6, 2012

Conversation

2 participants
Contributor

danielhfrank commented Feb 29, 2012

Man this was easier when sts just didn't return any errors...

async_sts will now pass back any errors it encounters to the caller. asyncdynamo has the logic to either raise the error immediately if it is a case of bad tokens, and otherwise backoff for about a minute or two (in case of network error) before raising an error

One thing that I missed - we do have a cache of pending requests in case we are unable to make some due to lack of current session token. I suppose it might be useful to somehow pass back the failed requests when raising an error, but I was not quite sure how. We can take another pass at that later

Contributor

danielhfrank commented Mar 5, 2012

@jehiah this should now be totally ready to go.

mreiferson added a commit that referenced this pull request Mar 6, 2012

Merge pull request #3 from bitly/sts_error_handling
add error handling for session token retrieval

@mreiferson mreiferson merged commit 965cc8a into master Mar 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment