Pass parsed json response for errors to be compatible with boto 2.3 #5

Merged
merged 2 commits into from Jan 10, 2013

Projects

None yet

3 participants

@rhettg
Contributor
rhettg commented Oct 28, 2012

The API for DynamoDBResponseError changed as a result of
boto/boto#625

@rhettg rhettg Pass parsed json response for errors to be compatible with boto 2.3
The API for DynamoDBResponseError changed as a result of
boto/boto#625
d0f9333
@TelegramSam

I would love this to be merged.

@danielhfrank
Contributor

Sorry guys, thought I had myself set up for notifications on this repo but have missed these requests - gimme a little bit of time to refamiliarize and I should be able to help make some progress here

@rhettg
Contributor
rhettg commented Jan 7, 2013

This latest commit isn't strictly Boto related, but I've seen some failures from DynamoDB that don't have JSON responses.

@danielhfrank
Contributor

Hey @rhettg let me know if you are planning on adding any more changes to this pull req, otherwise I can merge and get versions straightened out. Thanks for contributing!

@rhettg
Contributor
rhettg commented Jan 9, 2013

It seems pretty solid for now.

However, whatever condition causes us to hit that no-json response issue happens pretty rarely, don't think we've seen it in a few days.

I'd say go ahead and merge.

@danielhfrank
Contributor

:shipit:

@danielhfrank danielhfrank merged commit 3b2a447 into bitly:master Jan 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment