New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validator_test hang on Solaris, Plan 9 #107

Merged
merged 1 commit into from May 31, 2015

Conversation

2 participants
@mbland
Contributor

mbland commented May 31, 2015

On these platforms, the done <- true statement in during TearDown() was hanging, since the watcher_unsupported.go version was never draining the channel. Also took the opportunity to update the WatchForUpdates() signature to not return bool anymore.

I developed this on Solaris 11 running in a VM, and confirmed that it's compatible with OS X. I'll expect it'll work just as well with Linux and Windows, and am trying to figure out how to get Go set up on Plan 9 as we speak.

cc: @jehiah

Fix validator_test hang on Solaris, Plan 9
On these platforms, the `done <- true` statement in during TearDown() was
hanging, since the `watcher_unsupported.go` version was never draining the
channel. Also took the opportunity to update the WatchForUpdates() signature
to not return bool anymore.
@jehiah

This comment has been minimized.

Member

jehiah commented May 31, 2015

👍 anything else you expect to add here before we merge this?

@mbland

This comment has been minimized.

Contributor

mbland commented May 31, 2015

Nothing I expect, no. But if I manage to get git installed on Plan 9 and I find another problem, I'll be certain to open another PR. ;-)

jehiah added a commit that referenced this pull request May 31, 2015

Merge pull request #107 from 18F/fix-validator-test
Fix validator_test hang on Solaris, Plan 9

@jehiah jehiah merged commit 71b79ba into bitly:master May 31, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mbland mbland deleted the 18F:fix-validator-test branch Jun 1, 2015

@mbland

This comment has been minimized.

Contributor

mbland commented Jun 8, 2015

FYI, I finally managed to build and test on Plan 9, and all is well. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment