This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Fix validator_test hang on Solaris, Plan 9 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On these platforms, the `done <- true` statement in during TearDown() was hanging, since the `watcher_unsupported.go` version was never draining the channel. Also took the opportunity to update the WatchForUpdates() signature to not return bool anymore.
|
👍 anything else you expect to add here before we merge this? |
|
Nothing I expect, no. But if I manage to get git installed on Plan 9 and I find another problem, I'll be certain to open another PR. ;-) |
jehiah
added a commit
that referenced
this pull request
May 31, 2015
Fix validator_test hang on Solaris, Plan 9
|
FYI, I finally managed to build and test on Plan 9, and all is well. ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On these platforms, the
done <- truestatement in during TearDown() was hanging, since thewatcher_unsupported.goversion was never draining the channel. Also took the opportunity to update the WatchForUpdates() signature to not return bool anymore.I developed this on Solaris 11 running in a VM, and confirmed that it's compatible with OS X. I'll expect it'll work just as well with Linux and Windows, and am trying to figure out how to get Go set up on Plan 9 as we speak.
cc: @jehiah