allow ps_to_http to accept a secondary pubsub url #67

Merged
merged 1 commit into from Jun 29, 2012

Projects

None yet

2 participants

@sricola

No description provided.

@sricola

ready for review @mreiferson @jehiah

@mreiferson

@sricola - have you verified this works as intended? This is segfaulting for me.

I tested by:

  1. running this command: ./ps_to_http --pubsub-url=http://127.0.0.1:8090/sub?multipart=0 --secondary-pubsub-url=http://127.0.0.1:8091/sub?multipart=0 --destination-get-url=http://127.0.0.2/%s
  2. killing the pubsub on 8090
@mreiferson mreiferson commented on an outdated diff Jun 29, 2012
ps_to_http/ps_to_http.c
char *address;
int port;
char *path;
option_define_bool("version", OPT_OPTIONAL, 0, NULL, version_cb, VERSION);
option_define_str("pubsub_url", OPT_REQUIRED, "http://127.0.0.1:80/sub?multipart=0", &pubsub_url, NULL, "url of pubsub to read from");
+ option_define_str("secondary_pubsub_url", OPT_OPTIONAL, "http://127.0.0.1:80/sub?multipart=0", &secondary_pubsub_url, NULL, "url of pubsub to read from");
@mreiferson
mreiferson Jun 29, 2012

i actually dont think we want to specify a default here

@mreiferson

this should work

squash plz

@sricola

ready for merge @mreiferson

@mreiferson mreiferson merged commit 647f67d into bitly:master Jun 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment