New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with helm install notes #141

Closed
alexellis opened this Issue Feb 7, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@alexellis
Copy link

alexellis commented Feb 7, 2019

I was just running through the helm chart installation and saw this:

NOTES:
You should now be able to create sealed secrets.

1. Install client-side tool into /usr/local/bin/

GOOS=$(go env GOOS)
GOARCH=$(go env GOARCH)
wget https://github.com/bitnami-labs/sealed-secrets/releases/download/$release/kubeseal-$GOOS-$GOARCH
sudo install -m 755 kubeseal-$GOOS-$GOARCH /usr/local/bin/kubeseal

However, when running the command this always fails because $release is never defined and on Linux this generates the following invalid URL https://github.com/bitnami-labs/sealed-secrets/releases/download//kubeseal-linux-amd64.

I'd guess that having the release variable in the helm chart template would fix this.

What do you think?

@c-knowles

This comment has been minimized.

Copy link
Contributor

c-knowles commented Feb 7, 2019

You'll still need the release=$(curl... line from just above it on the installation instructions but sounds like perhaps you are following some other instructions, could you point at which ones? The current readme I think it would be good to separate out instructions for the CLI and server parts.

@alexellis

This comment has been minimized.

Copy link
Author

alexellis commented Feb 7, 2019

Hi thanks for getting back so soon. This is the output from helm after installing. Perhaps what you could do to fix this is something like just point to the latest URL or give the command to fetch the release variable in the helm chart output?

Alex

@anguslees

This comment has been minimized.

Copy link
Contributor

anguslees commented Feb 8, 2019

Thanks for the report. The helm chart is managed by different people, so I'm going to move this issue to the helm/charts repo. Please stay on the line, your call is important to us, etc...

@anguslees

This comment has been minimized.

Copy link
Contributor

anguslees commented Feb 8, 2019

(Moved to helm/charts#11258)

@anguslees anguslees closed this Feb 8, 2019

@anguslees anguslees added the bug label Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment